Make common utility to load views from nibs.

chrome/browser/ui/cocoa/select_file_dialog_mac.mm

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/select_file_dialog.h"
 
 #import <Cocoa/Cocoa.h>
 #include <CoreServices/CoreServices.h>
 
 #include <map>
 #include <set>
 #include <vector>
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #import "base/mac/cocoa_protocols.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #import "base/memory/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "grit/generated_resources.h"
+#import "ui/base/cocoa/nib_loading.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
-static const int kFileTypePopupTag = 1234;
+namespace {
+
+const int kFileTypePopupTag = 1234;
+
+}  // namespace
 
 class SelectFileDialogImpl;
 
 // A bridge class to act as the modal delegate to the save/open sheet and send
 // the results to the C++ class.
 @interface SelectFileDialogBridge : NSObject<NSOpenSavePanelDelegate> {
  @private
   SelectFileDialogImpl* selectFileDialogImpl_;  // WEAK; owns us
 }
 
@@ skipping 250 matching lines @@
       listener_->MultiFilesSelected(files, params);
     } else {
       listener_->FileSelected(files[0], index, params);
     }
   }
 }
 
 NSView* SelectFileDialogImpl::GetAccessoryView(const FileTypeInfo* file_types,
                                                int file_type_index) {
   DCHECK(file_types);
-  scoped_nsobject<NSNib> nib (
-      [[NSNib alloc] initWithNibNamed:@"SaveAccessoryView"
-                               bundle:base::mac::FrameworkBundle()]);
-  if (!nib)
+  NSView* accessory_view = ui::GetViewFromNib(@"SaveAccessoryView");
+  if (!accessory_view)
     return nil;
 
-  NSArray* objects;
-  BOOL success = [nib instantiateNibWithOwner:nil
-                              topLevelObjects:&objects];
-  if (!success)
-    return nil;
-  [objects makeObjectsPerformSelector:@selector(release)];
-
-  // This is a one-object nib, but IB insists on creating a second object, the
-  // NSApplication. I don't know why.
-  size_t view_index = 0;
-  while (view_index < [objects count] &&
-      ![[objects objectAtIndex:view_index] isKindOfClass:[NSView class]])
-    ++view_index;
-  DCHECK(view_index < [objects count]);
-  NSView* accessory_view = [objects objectAtIndex:view_index];
-
   NSPopUpButton* popup = [accessory_view viewWithTag:kFileTypePopupTag];
   DCHECK(popup);
 
   size_t type_count = file_types->extensions.size();
   for (size_t type = 0; type<type_count; ++type) {
     NSString* type_description;
     if (type < file_types->extension_description_overrides.size()) {
       type_description = base::SysUTF16ToNSString(
           file_types->extension_description_overrides[type]);
     } else {
@@ skipping 90 matching lines @@
                                          paths,
                                          index);
   [panel release];
 }
 
 - (BOOL)panel:(id)sender shouldShowFilename:(NSString *)filename {
   return selectFileDialogImpl_->ShouldEnableFilename(sender, filename);
 }
 
 @end