Issue 9982011: Mac content shell: Fix new browser window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9982011: Mac content shell: Fix new browser window. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
plz use chromium.org account, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mac content shell: Fix new browser window. This is a revert of most of r130140, and a better re-implementation thereof. BUG=120153 TEST=as described Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130723

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -16 lines)			Patch
M	content/shell/shell_application_mac.mm	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	content/shell/shell_browser_context.h	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	content/shell/shell_browser_context.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9982011/1

8 years, 8 months ago (2012-04-04 18:24:18 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-04 20:21:48 UTC) #4

Try job failure for 9982011-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages