Make sure toplevel final fields are initialized

compiler/java/com/google/dart/compiler/resolver/Resolver.java

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index 40277e8b6a1b7a17856d29b96412a2e0d1bad9e6..d40f3b7059096dac47ab5dad75d48cfdedb4b019 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -634,13 +634,9 @@ public class Resolver {
     public Element visitField(DartField node) {
       DartExpression expression = node.getValue();
       Modifiers modifiers = node.getModifiers();
-      boolean isStatic = modifiers.isStatic();
       boolean isFinal = modifiers.isFinal();
       boolean isTopLevel = ElementKind.of(currentHolder).equals(ElementKind.LIBRARY);
-
-      if (isTopLevel && isFinal) {
-        modifiers.makeStatic();

[scheglov, 2012/04/04 15:21:04]

We don't set static flag anymore.
I don't know if anybody used it, but if it passes all tests, then OK.

[zundel, 2012/04/04 17:49:31]

That's just the thing.  This code didn't set anything.  the correct code to do
that would have been

modifiers = modifiers.makeStatic

but then non one tests it, they only tested isStatic which wasn't reset.

I decided to scrap it because it really isn't a static field and I thought that
would just confuse people.

-      }
+      boolean isStatic = modifiers.isStatic();
 
       if (expression != null) {
         resolve(expression);
@@ -653,6 +649,8 @@ public class Resolver {
       } else if (isFinal) {
         if (isStatic) {
           onError(node, ResolverErrorCode.STATIC_FINAL_REQUIRES_VALUE);
+        } else if (isTopLevel) {
+          onError(node, ResolverErrorCode.TOPLEVEL_FINAL_REQUIRES_VALUE);          
         } else {
           // If a final instance field wasn't initialized at declaration, we must check
           // at construction time.