Issue 9981014: Revert "Revert 130697 - Reland r130462: Implement FeatureProvider for ExtensionAPI.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9981014: Revert "Revert 130697 - Reland r130462: Implement FeatureProvider for ExtensionAPI."" (Closed)

Created:
8 years, 8 months ago by Aaron Boodman

Modified:
8 years, 8 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Revert 130697 - Reland r130462: Implement FeatureProvider for ExtensionAPI."" This reverts commit b58edbf7df6f39ba3b3b1ad9dae415a79adf91a4. BUG=120069 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130771

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1556 lines, -500 lines)			Patch
M	chrome/browser/extensions/extension_event_router.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	7 chunks	+23 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_frontend.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/bookmarks.json	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.h	View	6 chunks	+82 lines, -20 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	9 chunks	+476 lines, -213 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api_unittest.cc	View	5 chunks	+279 lines, -57 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/common/extensions/feature.h	View	3 chunks	+39 lines, -36 lines	0 comments	Download
M	chrome/common/extensions/feature.cc	View	8 chunks	+66 lines, -30 lines	0 comments	Download
A	chrome/common/extensions/feature_provider.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/feature_unittest.cc	View	12 chunks	+238 lines, -95 lines	0 comments	Download
M	chrome/common/extensions/manifest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/common/extensions/manifest_feature.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/manifest_feature.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/permission_feature.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/permission_feature.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/simple_feature_provider.h	View	2 chunks	+12 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/simple_feature_provider.cc	View	4 chunks	+36 lines, -24 lines	0 comments	Download
M	chrome/common/extensions/simple_feature_provider_unittest.cc	View	2 chunks	+72 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/schema_generated_bindings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/v8_schema_registry.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/webstore_private/bundle/extension2.json	View	1 chunk	+1 line, -6 lines	0 comments	Download
A	chrome/test/data/extensions/extension_api_unittest/is_privileged_features_1.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/extension_api_unittest/is_privileged_features_2.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/extension_api_unittest/is_privileged_features_3.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/extension_api_unittest/is_privileged_features_4.json	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/extension_api_unittest/is_privileged_features_5.json	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 8 months ago (2012-04-04 19:23:38 UTC) #1

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/9981014/1

Expand Messages | Collapse Messages