Look up the correct constructor for default classes.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
 }
 
 class TreeElementMapping implements TreeElements {
@@ skipping 149 matching lines @@
     ClassElement defaultClass = defaultType.element;
     defaultClass.ensureResolved(compiler);
     if (defaultClass.isInterface()) {
       error(node, MessageKind.CANNOT_INSTANTIATE_INTERFACE,
             [defaultClass.name]);
     }
     // We have now established the following:
     // [intrface] is an interface, let's say "MyInterface".
     // [defaultClass] is a class, let's say "MyClass".
 
-    // First look up the constructor named "MyInterface.name".
-    constructor.defaultImplementation =
-      defaultClass.lookupConstructor(constructor.name);
+    // If the default class implements the interface then we must use the
+    // default class' name. Otherwise we look for a factory with the name
+    // of the interface.
+    SourceString name;
+    if (defaultClass.implementsInterface(intrface)) {
+      name = new SourceString(constructor.name.slowToString().replaceFirst(

[ahe, 2012/04/10 14:30:38]

Please add "TODO(ahe): Don't use string replacement here".

[floitsch, 2012/04/11 11:40:56]

Done.

+                 intrface.name.slowToString(),
+                 defaultClass.name.slowToString()));
+    } else {
+      name = constructor.name;
+    }
+    constructor.defaultImplementation = defaultClass.lookupConstructor(name);
 
-    // If that fails, try looking up "MyClass.name".
     if (constructor.defaultImplementation === null) {
-      SourceString name =
-          new SourceString(constructor.name.slowToString().replaceFirst(
-              intrface.name.slowToString(),
-              defaultClass.name.slowToString()));
-      constructor.defaultImplementation = defaultClass.lookupConstructor(name);
-
-      if (constructor.defaultImplementation === null) {
-        // We failed find a constrcutor named either
-        // "MyInterface.name" or "MyClass.name".
-        error(node, MessageKind.CANNOT_FIND_CONSTRUCTOR2,
-              [constructor.name, name]);
-      }
+      // We failed to find a constructor named either
+      // "MyInterface.name" or "MyClass.name".
+      error(node,
+            MessageKind.CANNOT_FIND_CONSTRUCTOR2,
+            [name, defaultClass.name]);
     }
   }
 
   TreeElements resolveField(Element element) {
     Node tree = element.parseNode(compiler);
     ResolverVisitor visitor = new ResolverVisitor(compiler, element);
     initializerDo(tree, visitor.visit);
     return visitor.mapping;
   }
 
@@ skipping 1594 matching lines @@
 
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) {
     return library.find(name);
   }
 
   Element add(Element element) {
     throw "Cannot add an element in the top scope";
   }
 }