Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1878)

Unified Diff: content/public/browser/resource_dispatcher_host_login_delegate.h

Issue 9980002: Mac content shell: HTTP auth. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removed extraneous forward declare Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/resource_dispatcher_host_login_delegate.h
diff --git a/content/public/browser/resource_dispatcher_host_login_delegate.h b/content/public/browser/resource_dispatcher_host_login_delegate.h
index 4701240405bf4c8ac64b6ec2d3c418b32d6c115a..6cd63752104daacc588dc7647e0cde300b3fe428 100644
--- a/content/public/browser/resource_dispatcher_host_login_delegate.h
+++ b/content/public/browser/resource_dispatcher_host_login_delegate.h
@@ -12,15 +12,17 @@
namespace content {
-// Interface for getting login credentials for HTTP auth requests. When the
-// implementation has the credentials, it shoudl call the Requests's SetAuth
-// method.
+// Interface for getting login credentials for HTTP auth requests. If the
+// login delegate obtains credentials, it should call the URLRequest's SetAuth
+// method. If the user cancels, the login delegate should call the URLRequest's
+// CancelAuth instead. And in either case, it must make a call to
+// ResourceDispatcherHost::ClearLoginDelegateForRequest.
class CONTENT_EXPORT ResourceDispatcherHostLoginDelegate
: public base::RefCountedThreadSafe<ResourceDispatcherHostLoginDelegate> {
public:
virtual ~ResourceDispatcherHostLoginDelegate() {}
- // Notify the delegate that the request was cancelled.
+ // Notify the login delegate that the request was cancelled.
// This function can only be called from the IO thread.
virtual void OnRequestCancelled() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698