Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6577)

Unified Diff: chrome/browser/extensions/image_loading_tracker.h

Issue 9979001: Attempt to load component extension favicon from the resources first. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/image_loading_tracker.h
===================================================================
--- chrome/browser/extensions/image_loading_tracker.h (revision 131549)
+++ chrome/browser/extensions/image_loading_tracker.h (working copy)
@@ -122,6 +122,13 @@
void OnImageLoaded(SkBitmap* image, const ExtensionResource& resource,
const gfx::Size& original_size, int id, bool should_cache);
+ // Checks whether image is a component extension resource. Returns false
+ // if a given |resource| does not have a corresponding image in bundled
+ // resources. Otherwise fills |resource_id|.
+ bool IsComponentExtensionResource(const Extension* extension,
+ const ExtensionResource& resource,
+ int& resource_id) const;
+
// content::NotificationObserver method. If an extension is uninstalled while
// we're waiting for the image we remove the entry from load_map_.
virtual void Observe(int type,
@@ -143,6 +150,8 @@
content::NotificationRegistrar registrar_;
+ friend class ImageLoadingTrackerTest;
Finnur 2012/04/11 17:38:13 FRIEND_TEST_ALL_PREFIXES instead?
dgozman 2012/04/12 11:47:24 Done.
+
DISALLOW_COPY_AND_ASSIGN(ImageLoadingTracker);
};

Powered by Google App Engine
This is Rietveld 408576698