Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 9979001: Attempt to load component extension favicon from the resources first. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h" 5 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/memory/ref_counted_memory.h" 9 #include "base/memory/ref_counted_memory.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 return; 119 return;
120 } 120 }
121 121
122 ExtensionIconRequest* request = GetData(request_id); 122 ExtensionIconRequest* request = GetData(request_id);
123 ExtensionResource icon = 123 ExtensionResource icon =
124 request->extension->GetIconResource(request->size, request->match); 124 request->extension->GetIconResource(request->size, request->match);
125 125
126 if (icon.relative_path().empty()) { 126 if (icon.relative_path().empty()) {
127 LoadIconFailed(request_id); 127 LoadIconFailed(request_id);
128 } else { 128 } else {
129 if (request->extension->location() == Extension::COMPONENT &&
130 TryLoadingComponentExtensionImage(icon, request_id)) {
131 return;
132 }
133 LoadExtensionImage(icon, request_id); 129 LoadExtensionImage(icon, request_id);
134 } 130 }
135 } 131 }
136 132
137 void ExtensionIconSource::LoadIconFailed(int request_id) { 133 void ExtensionIconSource::LoadIconFailed(int request_id) {
138 ExtensionIconRequest* request = GetData(request_id); 134 ExtensionIconRequest* request = GetData(request_id);
139 ExtensionResource icon = 135 ExtensionResource icon =
140 request->extension->GetIconResource(request->size, request->match); 136 request->extension->GetIconResource(request->size, request->match);
141 137
142 if (request->size == ExtensionIconSet::EXTENSION_ICON_BITTY) 138 if (request->size == ExtensionIconSet::EXTENSION_ICON_BITTY)
143 LoadFaviconImage(request_id); 139 LoadFaviconImage(request_id);
144 else 140 else
145 LoadDefaultImage(request_id); 141 LoadDefaultImage(request_id);
146 } 142 }
147 143
148 const SkBitmap* ExtensionIconSource::GetWebStoreImage() {
149 if (!web_store_icon_data_.get())
150 web_store_icon_data_.reset(LoadImageByResourceId(IDR_WEBSTORE_ICON));
151
152 return web_store_icon_data_.get();
153 }
154
155 const SkBitmap* ExtensionIconSource::GetDefaultAppImage() { 144 const SkBitmap* ExtensionIconSource::GetDefaultAppImage() {
156 if (!default_app_data_.get()) 145 if (!default_app_data_.get())
157 default_app_data_.reset(LoadImageByResourceId(IDR_APP_DEFAULT_ICON)); 146 default_app_data_.reset(LoadImageByResourceId(IDR_APP_DEFAULT_ICON));
158 147
159 return default_app_data_.get(); 148 return default_app_data_.get();
160 } 149 }
161 150
162 const SkBitmap* ExtensionIconSource::GetDefaultExtensionImage() { 151 const SkBitmap* ExtensionIconSource::GetDefaultExtensionImage() {
163 if (!default_extension_data_.get()) { 152 if (!default_extension_data_.get()) {
164 default_extension_data_.reset( 153 default_extension_data_.reset(
(...skipping 12 matching lines...) Expand all
177 bitmap = *image; 166 bitmap = *image;
178 167
179 ClearData(request_id); 168 ClearData(request_id);
180 SendResponse(request_id, BitmapToMemory(&bitmap)); 169 SendResponse(request_id, BitmapToMemory(&bitmap));
181 } 170 }
182 171
183 void ExtensionIconSource::LoadDefaultImage(int request_id) { 172 void ExtensionIconSource::LoadDefaultImage(int request_id) {
184 ExtensionIconRequest* request = GetData(request_id); 173 ExtensionIconRequest* request = GetData(request_id);
185 const SkBitmap* default_image = NULL; 174 const SkBitmap* default_image = NULL;
186 175
187 if (request->extension->id() == extension_misc::kWebStoreAppId) 176 if (request->extension->is_app())
188 default_image = GetWebStoreImage();
189 else if (request->extension->is_app())
190 default_image = GetDefaultAppImage(); 177 default_image = GetDefaultAppImage();
191 else 178 else
192 default_image = GetDefaultExtensionImage(); 179 default_image = GetDefaultExtensionImage();
193 180
194 SkBitmap resized_image(skia::ImageOperations::Resize( 181 SkBitmap resized_image(skia::ImageOperations::Resize(
195 *default_image, skia::ImageOperations::RESIZE_LANCZOS3, 182 *default_image, skia::ImageOperations::RESIZE_LANCZOS3,
196 request->size, request->size)); 183 request->size, request->size));
197 184
198 // There are cases where Resize returns an empty bitmap, for example if you 185 // There are cases where Resize returns an empty bitmap, for example if you
199 // ask for an image too large. In this case it is better to return the default 186 // ask for an image too large. In this case it is better to return the default
200 // image than returning nothing at all. 187 // image than returning nothing at all.
201 if (resized_image.empty()) 188 if (resized_image.empty())
202 resized_image = *default_image; 189 resized_image = *default_image;
203 190
204 FinalizeImage(&resized_image, request_id); 191 FinalizeImage(&resized_image, request_id);
205 } 192 }
206 193
207 bool ExtensionIconSource::TryLoadingComponentExtensionImage(
208 const ExtensionResource& icon, int request_id) {
209 ExtensionIconRequest* request = GetData(request_id);
210 FilePath directory_path = request->extension->path();
211 FilePath relative_path = directory_path.BaseName().Append(
212 icon.relative_path());
213 for (size_t i = 0; i < kComponentExtensionResourcesSize; ++i) {
214 FilePath bm_resource_path =
215 FilePath().AppendASCII(kComponentExtensionResources[i].name);
216 bm_resource_path = bm_resource_path.NormalizePathSeparators();
217 if (relative_path == bm_resource_path) {
218 scoped_ptr<SkBitmap> decoded(LoadImageByResourceId(
219 kComponentExtensionResources[i].value));
220 FinalizeImage(decoded.get(), request_id);
221 return true;
222 }
223 }
224 return false;
225 }
226
227 void ExtensionIconSource::LoadExtensionImage(const ExtensionResource& icon, 194 void ExtensionIconSource::LoadExtensionImage(const ExtensionResource& icon,
228 int request_id) { 195 int request_id) {
229 ExtensionIconRequest* request = GetData(request_id); 196 ExtensionIconRequest* request = GetData(request_id);
230 tracker_map_[next_tracker_id_++] = request_id; 197 tracker_map_[next_tracker_id_++] = request_id;
231 tracker_->LoadImage(request->extension, 198 tracker_->LoadImage(request->extension,
232 icon, 199 icon,
233 gfx::Size(request->size, request->size), 200 gfx::Size(request->size, request->size),
234 ImageLoadingTracker::DONT_CACHE); 201 ImageLoadingTracker::DONT_CACHE);
235 } 202 }
236 203
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 327
361 void ExtensionIconSource::ClearData(int request_id) { 328 void ExtensionIconSource::ClearData(int request_id) {
362 std::map<int, ExtensionIconRequest*>::iterator i = 329 std::map<int, ExtensionIconRequest*>::iterator i =
363 request_map_.find(request_id); 330 request_map_.find(request_id);
364 if (i == request_map_.end()) 331 if (i == request_map_.end())
365 return; 332 return;
366 333
367 delete i->second; 334 delete i->second;
368 request_map_.erase(i); 335 request_map_.erase(i);
369 } 336 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698