Revert 130697 - Reland r130462: Implement FeatureProvider for ExtensionAPI."

chrome/common/extensions/feature.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/feature.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 33 matching lines @@
 
 // TODO(aa): Can we replace all this manual parsing with JSON schema stuff?
 
 void ParseSet(const DictionaryValue* value,
               const std::string& property,
               std::set<std::string>* set) {
   ListValue* list_value = NULL;
   if (!value->GetList(property, &list_value))
     return;
 
-  set->clear();
   for (size_t i = 0; i < list_value->GetSize(); ++i) {
     std::string str_val;
     CHECK(list_value->GetString(i, &str_val)) << property << " " << i;
     set->insert(str_val);
   }
 }
 
 template<typename T>
 void ParseEnum(const std::string& string_value,
                T* enum_value,
                const std::map<std::string, T>& mapping) {
   typename std::map<std::string, T>::const_iterator iter =
       mapping.find(string_value);
   CHECK(iter != mapping.end()) << string_value;
   *enum_value = iter->second;
 }
 
 template<typename T>
 void ParseEnum(const DictionaryValue* value,
                const std::string& property,
                T* enum_value,
                const std::map<std::string, T>& mapping) {
   std::string string_value;
   if (!value->GetString(property, &string_value))
     return;
-
   ParseEnum(string_value, enum_value, mapping);
 }
 
 template<typename T>
 void ParseEnumSet(const DictionaryValue* value,
                   const std::string& property,
                   std::set<T>* enum_set,
                   const std::map<std::string, T>& mapping) {
-  if (!value->HasKey(property))
-    return;
-
-  enum_set->clear();
-
   std::string property_string;
   if (value->GetString(property, &property_string)) {
     if (property_string == "all") {
       for (typename std::map<std::string, T>::const_iterator j =
                mapping.begin(); j != mapping.end(); ++j) {
         enum_set->insert(j->second);
       }
     }
     return;
   }
@@ skipping 12 matching lines @@
 
 namespace extensions {
 
 Feature::Feature()
   : location_(UNSPECIFIED_LOCATION),
     platform_(UNSPECIFIED_PLATFORM),
     min_manifest_version_(0),
     max_manifest_version_(0) {
 }
 
-Feature::Feature(const Feature& other)
-    : whitelist_(other.whitelist_),
-      extension_types_(other.extension_types_),
-      contexts_(other.contexts_),
-      location_(other.location_),
-      platform_(other.platform_),
-      min_manifest_version_(other.min_manifest_version_),
-      max_manifest_version_(other.max_manifest_version_) {
-}
-
 Feature::~Feature() {
 }
 
-bool Feature::Equals(const Feature& other) const {
-  return whitelist_ == other.whitelist_ &&
-      extension_types_ == other.extension_types_ &&
-      contexts_ == other.contexts_ &&
-      location_ == other.location_ &&
-      platform_ == other.platform_ &&
-      min_manifest_version_ == other.min_manifest_version_ &&
-      max_manifest_version_ == other.max_manifest_version_;
+// static
+scoped_ptr<Feature> Feature::Parse(const DictionaryValue* value) {
+  scoped_ptr<Feature> feature(new Feature());
+
+  ParseSet(value, "whitelist", feature->whitelist());
+  ParseEnumSet<Extension::Type>(value, "extension_types",
+                                feature->extension_types(),
+                                g_mappings.Get().extension_types);
+  ParseEnumSet<Context>(value, "contexts", feature->contexts(),
+                        g_mappings.Get().contexts);
+  ParseEnum<Location>(value, "location", &feature->location_,
+                      g_mappings.Get().locations);
+  ParseEnum<Platform>(value, "platform", &feature->platform_,
+                      g_mappings.Get().platforms);
+
+  value->GetInteger("min_manifest_version", &feature->min_manifest_version_);
+  value->GetInteger("max_manifest_version", &feature->max_manifest_version_);
+
+  return feature.Pass();
 }
 
 // static
 Feature::Platform Feature::GetCurrentPlatform() {
 #if defined(OS_CHROMEOS)
   return CHROMEOS_PLATFORM;
 #else
   return UNSPECIFIED_PLATFORM;
 #endif
 }
 
 // static
 Feature::Location Feature::ConvertLocation(Extension::Location location) {
   if (location == Extension::COMPONENT)
     return COMPONENT_LOCATION;
   else
     return UNSPECIFIED_LOCATION;
 }
 
-void Feature::Parse(const DictionaryValue* value) {
-  ParseSet(value, "whitelist", &whitelist_);
-  ParseEnumSet<Extension::Type>(value, "extension_types", &extension_types_,
-                                g_mappings.Get().extension_types);
-  ParseEnumSet<Context>(value, "contexts", &contexts_,
-                        g_mappings.Get().contexts);
-  ParseEnum<Location>(value, "location", &location_,
-                      g_mappings.Get().locations);
-  ParseEnum<Platform>(value, "platform", &platform_,
-                      g_mappings.Get().platforms);
-  value->GetInteger("min_manifest_version", &min_manifest_version_);
-  value->GetInteger("max_manifest_version", &max_manifest_version_);
-}
-
 std::string Feature::GetErrorMessage(Feature::Availability result) {
   switch (result) {
     case IS_AVAILABLE:
       return "";
     case NOT_FOUND_IN_WHITELIST:
       return "Not allowed for specified extension ID.";
     case INVALID_TYPE:
       return "Not allowed for specified package type (theme, app, etc.).";
     case INVALID_CONTEXT:
       return "Not allowed for specified context type content script, extension "
           "page, web page, etc.).";
     case INVALID_LOCATION:
       return "Not allowed for specified install location.";
     case INVALID_PLATFORM:
       return "Not allowed for specified platform.";
     case INVALID_MIN_MANIFEST_VERSION:
       return base::StringPrintf("Requires manifest version of at least %d.",
                                 min_manifest_version_);
     case INVALID_MAX_MANIFEST_VERSION:
       return base::StringPrintf("Requires manifest version of %d or lower.",
                                 max_manifest_version_);
     default:
       CHECK(false);
       return "";
   }
 }
 
-Feature::Availability Feature::IsAvailableToManifest(
-    const std::string& extension_id,
-    Extension::Type type,
-    Location location,
-    int manifest_version,
-    Platform platform) const {
+Feature::Availability Feature::IsAvailable(const std::string& extension_id,
+                                           Extension::Type type,
+                                           Location location,
+                                           Context context,
+                                           Platform platform,
+                                           int manifest_version) {
   // Component extensions can access any feature.
   if (location == COMPONENT_LOCATION)
     return IS_AVAILABLE;
 
   if (!whitelist_.empty()) {
     if (whitelist_.find(extension_id) == whitelist_.end()) {
       // TODO(aa): This is gross. There should be a better way to test the
       // whitelist.
       CommandLine* command_line = CommandLine::ForCurrentProcess();
       if (!command_line->HasSwitch(switches::kWhitelistedExtensionID))
         return NOT_FOUND_IN_WHITELIST;
 
       std::string whitelist_switch_value =
           CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
               switches::kWhitelistedExtensionID);
       if (extension_id != whitelist_switch_value)
         return NOT_FOUND_IN_WHITELIST;
     }
   }
 
   if (!extension_types_.empty() &&
       extension_types_.find(type) == extension_types_.end()) {
     return INVALID_TYPE;
   }
 
+  if (!contexts_.empty() &&
+      contexts_.find(context) == contexts_.end()) {
+    return INVALID_CONTEXT;
+  }
+
   if (location_ != UNSPECIFIED_LOCATION && location_ != location)
     return INVALID_LOCATION;
 
   if (platform_ != UNSPECIFIED_PLATFORM && platform_ != platform)
     return INVALID_PLATFORM;
 
   if (min_manifest_version_ != 0 && manifest_version < min_manifest_version_)
     return INVALID_MIN_MANIFEST_VERSION;
 
   if (max_manifest_version_ != 0 && manifest_version > max_manifest_version_)
     return INVALID_MAX_MANIFEST_VERSION;
 
   return IS_AVAILABLE;
 }
 
-Feature::Availability Feature::IsAvailableToContext(
-    const Extension* extension,
-    Feature::Context context,
-    Feature::Platform platform) const {
-  Availability result = IsAvailableToManifest(
-      extension->id(),
-      extension->GetType(),
-      ConvertLocation(extension->location()),
-      extension->manifest_version(),
-      platform);
-  if (result != IS_AVAILABLE)
-    return result;
-
-  if (!contexts_.empty() &&
-      contexts_.find(context) == contexts_.end()) {
-    return INVALID_CONTEXT;
-  }
-
-  return IS_AVAILABLE;
-}
-
 }  // namespace