Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9977021: Add ExtensionSytem::Get(Profile*) as a wrapper around (Closed)

Created:
8 years, 8 months ago by Matt Perry
Modified:
8 years, 8 months ago
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, kkania, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, robertshield, brettw-cc_chromium.org, darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Add ExtensionSytem::Get(Profile*) as a wrapper around ExtensionSystemFactory::GetForProfile. Switch callsites to use that. BUG=104095 TEST=no TBR=akalin TBR=mirandac TBR=jrg TBR=arv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130785

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -76 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 7 chunks +6 lines, -7 lines 0 comments Download
chrome/browser/extensions/extension_system.h View 1 chunk +4 lines, -0 lines 2 comments Download
M chrome/browser/extensions/extension_system.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Perry
8 years, 8 months ago (2012-04-04 22:43:52 UTC) #1
Yoyo Zhou
LGTM but for the name. http://codereview.chromium.org/9977021/diff/1/chrome/browser/extensions/extension_system.h File chrome/browser/extensions/extension_system.h (right): http://codereview.chromium.org/9977021/diff/1/chrome/browser/extensions/extension_system.h#newcode42 chrome/browser/extensions/extension_system.h:42: static ExtensionSystem* Get(Profile* profile); ...
8 years, 8 months ago (2012-04-04 22:54:20 UTC) #2
Matt Perry
http://codereview.chromium.org/9977021/diff/1/chrome/browser/extensions/extension_system.h File chrome/browser/extensions/extension_system.h (right): http://codereview.chromium.org/9977021/diff/1/chrome/browser/extensions/extension_system.h#newcode42 chrome/browser/extensions/extension_system.h:42: static ExtensionSystem* Get(Profile* profile); On 2012/04/04 22:54:21, Yoyo Zhou ...
8 years, 8 months ago (2012-04-04 22:56:44 UTC) #3
Matt Perry
I need OWNERS approval for these directories (just a renaming change): akalin: OWNERS review for ...
8 years, 8 months ago (2012-04-05 00:14:28 UTC) #4
John Grabowski
OWNERS LGTM for chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
8 years, 8 months ago (2012-04-05 00:49:54 UTC) #5
Miranda Callahan
8 years, 8 months ago (2012-04-05 13:43:27 UTC) #6 
On 2012/04/05 00:49:54, John Grabowski wrote:
> OWNERS LGTM for
> chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

OWNERS LGTM for profiles/*

Powered by Google App Engine
This is Rietveld 408576698