Resolve the conflict that auto-launch has with the background mode feature (part 1).

chrome/browser/profiles/profile_shortcut_manager_win.cc

Index: chrome/browser/profiles/profile_shortcut_manager_win.cc
===================================================================
--- chrome/browser/profiles/profile_shortcut_manager_win.cc	(revision 132169)
+++ chrome/browser/profiles/profile_shortcut_manager_win.cc	(working copy)
@@ -208,10 +208,15 @@
 
 void DeleteAutoLaunchValueForProfile(
     const FilePath& profile_path) {
-  if (auto_launch_util::WillLaunchAtLogin(FilePath(),
-                                          profile_path.BaseName().value())) {
-      auto_launch_util::SetWillLaunchAtLogin(
-          false, FilePath(), profile_path.BaseName().value());
+  if (auto_launch_util::WillLaunchAtLoginWithSwitch(
+      FilePath(),
+      profile_path.BaseName().value(),
+      switches::kAutoLaunchAtStartup)) {
+    auto_launch_util::SetWillLaunchAtLogin(

[grt (UTC plus 2), 2012/04/16 15:30:14]

this doesn't seem to scale very well: all callsites that adjust one "feature" of
the Run keys now need to know about all features for all other callsites.  can
the interface to the Run key be simplified so that the enable/disable autolaunch
sites only need to care about flipping that one bit, and let the underlying
implementation take care of preserving other settings or deleting the Run value
altogether where appropriate?

[Finnur, 2012/04/16 15:43:48]

Can you elaborate a bit? Are you talking about an enum:

DISABLE_ALL,
DISABLE_AUTO_START,
DISABLE_BACKGROUND_MODE,
ENABLE_AUTO_START,
ENABLE_BACKGROUND_MODE,

... that we pass in to SetWillLaunchAtLogin instead of the bools?



On 2012/04/16 15:30:14, grt wrote:

[grt (UTC plus 2), 2012/04/16 15:48:47]

My first thought was just different functions: one (or one set) related to
autolaunch and another related to background mode.  The underlying
implementation of them would know that they use different command-line args in a
shared Run key, but the callers don't need to know that.

On 2012/04/16 15:43:48, Finnur wrote:

+        FilePath(),
+        profile_path.BaseName().value(),
+        auto_launch_util::FLAG_DISABLE,    // Auto launch.
+        auto_launch_util::FLAG_PRESERVE);  // Background mode.
   }
 }