Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 9972006: Fix lineprocessor sample and include it in the gyp build. (Closed)

Created:
8 years, 8 months ago by Yang
Modified:
8 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix lineprocessor sample and include it in the gyp build. Based on a patch by Peter Rybin <peter.rybin@gmail.com>; https://chromiumcodereview.appspot.com/10081030/ BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M samples/lineprocessor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/samples.gyp View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL.
8 years, 8 months ago (2012-04-16 09:19:11 UTC) #1
Jakob Kummerow
8 years, 8 months ago (2012-04-16 09:22:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698