Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/tools/build/win/FILES.cfg

Issue 9972003: Flag files accidentally removed from default filegroup processing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/win/FILES.cfg
diff --git a/chrome/tools/build/win/FILES.cfg b/chrome/tools/build/win/FILES.cfg
index 7c76b6c65e377294bb88903a503c33935bd4c1af..2c21743b6757f31a9caca51488b339e84a746c99 100644
--- a/chrome/tools/build/win/FILES.cfg
+++ b/chrome/tools/build/win/FILES.cfg
@@ -20,8 +20,14 @@
# NOTE: This flag will not apply if more than one file has the
# same 'archive' name, which will create a zip of all the
# files instead.
-# filegroup: List of named groups to which this file belongs (e.g. 'symbols'
-# for symbol processing, 'tests' for running tests, etc.).
+# filegroup: List of named groups to which this file belongs.
+# default: Legacy "default archive". TODO(mmoss): These should
+# be updated to specify an 'archive' name and then this
+# filegroup and the related archive_utils.ParseLegacyList()
+# should go away.
+# symbols: Legacy symbol processing (will go away after
+# archive_build.py is updated to use the 'archive' field).
+# symsrc: Files to upload to the symbol server.
# optional: List of buildtypes for which the file might not exist, and it's not
# considered an error.
@@ -45,19 +51,19 @@ FILES = [
'filename': 'chrome.exe',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
{
'filename': 'nacl64.exe',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
{
'filename': 'chrome.dll',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
{
'filename': 'crash_service.exe',
@@ -414,7 +420,7 @@ FILES = [
'filename': 'ppGoogleNaClPluginChrome.dll',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
# Windows Chrome does not have separate x86-32 and x86-64 installs.
# A single install supports both x86-32 and x86-64 versions of NaCl,
@@ -493,25 +499,25 @@ FILES = [
'filename': 'npchrome_frame.dll',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
{
'filename': 'chrome_launcher.exe',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
{
'filename': 'chrome_frame_helper.exe',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
{
'filename': 'chrome_frame_helper.dll',
'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
- 'filegroup': ['symsrc'],
+ 'filegroup': ['default', 'symsrc'],
},
# Perf testing binary:
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698