Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 9969198: Fix a bug in heap profile tracing of closures. (Closed)

Created:
8 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in heap profile tracing of closures. The heap profile tracers assumed that a closure always closed over a function context. This is obviously not true (e.g., function expressions nested inside catch or with). This assumption could lead to using a function's scope info to interpret a catch or with context. R=vegorov@chromium.org BUG=v8:2078 TEST= Committed: https://code.google.com/p/v8/source/detail?r=11348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
8 years, 8 months ago (2012-04-17 10:37:03 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-04-17 10:41:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698