Issue 9969196: Make SubStringStub more robust wrt unsafe arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969196: Make SubStringStub more robust wrt unsafe arguments. (Closed)

Created:
8 years, 8 months ago by Yang

Modified:
8 years, 8 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make SubStringStub more robust wrt unsafe arguments. BUG= TEST=test-strings/RobustSubStringStub Committed: https://code.google.com/p/v8/source/detail?r=11349

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -67 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+4 lines, -28 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	2 chunks	+5 lines, -38 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Also ports changes from https://chromiumcodereview.appspot.com/9625003 (r10957) to X64 and ARM.

8 years, 8 months ago (2012-04-17 07:58:07 UTC) #1

Erik Corry

8 years, 8 months ago (2012-04-17 09:06:58 UTC) #2

LGTM

http://codereview.chromium.org/9969196/diff/1/test/cctest/test-strings.cc
File test/cctest/test-strings.cc (right):

http://codereview.chromium.org/9969196/diff/1/test/cctest/test-strings.cc#new...
test/cctest/test-strings.cc:634: CompileRun("%_SubString('abcdef', 5, 2)");
I'd like more tests here.  Negative numbers, borderline numbers, heap numbers,
input strings large enough to trigger the creation of SlicedStrings, slices of
slices where the args are out of bounds for the slice, but not for the
underlying string.

Expand Messages | Collapse Messages