- Remove more String operator + from tests.

tests/language/src/StringConcatTest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // String concatenation test.
 
 interface V {
   static final Version = "7.3.5.3";
 }
 
 
 class StringConcatTest {
 
   static final Tag = "version-" + V.Version;

[hausner, 2012/04/11 18:01:24]

There are many more cases of string + in this test. Maybe the whole test should
be removed, it hardly makes any sense now.

[Ivan Posva, 2012/04/13 13:29:17]

I only addressed dynamically executed + operations on Strings. This one is a
constant and handled in the compiler. Since I did not have your pending change
this was not flagged.

 
   static Answer() {
     return 42;
   }
 
   static testMain() {
     int nofExceptions = 0;
 
     var x = 3;
     var y = 5;
     Expect.equals("" + x + y, "35");
     Expect.equals(x + y, 8);
 
     var s1 = "The answer is " + Answer() + '.';
     Expect.equals(s1, "The answer is 42.");
 
     Expect.equals("version-7.3.5.3", Tag);
 
     // Adding a number to a string value creates a new, concatenated
     // string.
     s1 = "Grandmaster Flash and the Furious ";
-    s1 = s1 + (4 + 1);
+    s1 = "$s1${4 + 1}";
     Expect.equals(true, s1.endsWith("Furious 5"));
 
     // Adding a string to a number is not supported.
     try {
       String cantDo = x + " should't work";  // throws noSuchMethodException.
       Expect.equals(1, 0);  // this should never be executed.
     } catch(NoSuchMethodException e) {
       // In default mode.
       nofExceptions++;
     } catch (TypeError e) {
@@ skipping 15 matching lines @@
     Expect.equals(true, fake === "Milli Vanilli");
     Expect.equals(true, fake === "Milli " + 'Vanilli');
 
     Expect.equals(nofExceptions, 1);
   }
 }
 
 main() {
   StringConcatTest.testMain();
 }