SetCapture of mouse events in partial screenshot. Mouse events are routed to the capture window. I…

SetCapture of mouse events in partial screenshot. Mouse events are routed to the capture window.  If the user presses Ctrl-Shift-F5 when a context menu appears, all of the mouse events will go to the menu instead of partial screenshot view, which causes unexpected behaviors.


BUG=120653
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132155

[sky, 2012-04-11 15:34:10]

I'm not that familiar with this code. What is the lifetime of the view? Should
it listen for capture changes and cancel if that happens?

[Jun Mukai, 2012-04-11 15:58:39]

On 2012/04/11 15:34:10, sky wrote:
> I'm not that familiar with this code. What is the lifetime of the view? Should
> it listen for capture changes and cancel if that happens?

This is the region selector for Ctrl-Shift-F5, and conceptually nobody else
should cancel it... but yes, it should still listen for capture changes in case.
 I'll do it tomorrow.

[Jun Mukai, 2012-04-12 07:35:07]

On 2012/04/11 15:58:39, Jun Mukai wrote:
> On 2012/04/11 15:34:10, sky wrote:
> > I'm not that familiar with this code. What is the lifetime of the view?
Should
> > it listen for capture changes and cancel if that happens?
> 
> This is the region selector for Ctrl-Shift-F5, and conceptually nobody else
> should cancel it... but yes, it should still listen for capture changes in
case.
>  I'll do it tomorrow.

Done.

[sky, 2012-04-12 15:30:45]

LGTM

http://codereview.chromium.org/9969149/diff/4001/ash/wm/partial_screenshot_vi...
File ash/wm/partial_screenshot_view.cc (right):

http://codereview.chromium.org/9969149/diff/4001/ash/wm/partial_screenshot_vi...
ash/wm/partial_screenshot_view.cc:62: // TODO(mukai): introduce stacking
mechanism to capture window to
To have menus stay on screen in this scenario will lead to all sorts of
problems. Best to close the menu like you have.

[Jun Mukai, 2012-04-13 06:11:28]

Thanks.  will submit soon.

http://codereview.chromium.org/9969149/diff/4001/ash/wm/partial_screenshot_vi...
File ash/wm/partial_screenshot_view.cc (right):

http://codereview.chromium.org/9969149/diff/4001/ash/wm/partial_screenshot_vi...
ash/wm/partial_screenshot_view.cc:62: // TODO(mukai): introduce stacking
mechanism to capture window to
On 2012/04/12 15:30:45, sky wrote:
> To have menus stay on screen in this scenario will lead to all sorts of
> problems. Best to close the menu like you have.

Then, removed the TODO.

[Daniel Erat, 2012-04-16 16:48:49]

lgtm

https://chromiumcodereview.appspot.com/9969149/diff/8002/ash/wm/partial_scree...
File ash/wm/partial_screenshot_view.cc (right):

https://chromiumcodereview.appspot.com/9969149/diff/8002/ash/wm/partial_scree...
ash/wm/partial_screenshot_view.cc:13: #include "ui/base/events.h"
nit: this should come after ui/base/cursor/cursor.h