Issue 9969148: Hide scanning notification when device with no media is detected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969148: Hide scanning notification when device with no media is detected. (Closed)

Created:
8 years, 8 months ago by tbarzic

Modified:
8 years, 8 months ago

Reviewers:
Ben Chan

CC:
chromium-reviews, nkostylev+watch_chromium.org, tbarzic+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hide scanning notification when device with no media is detected. Also, we should not allow burning to those devices. BUG=chromium-os:27894 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131717

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/imageburner/burn_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Chan

lgtm https://chromiumcodereview.appspot.com/9969148/diff/2001/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right): https://chromiumcodereview.appspot.com/9969148/diff/2001/chrome/browser/chromeos/extensions/file_browser_event_router.cc#newcode421 chrome/browser/chromeos/extensions/file_browser_event_router.cc:421: // Either the disk was mounted or it ...

8 years, 8 months ago (2012-04-11 02:47:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/9969148/4004

8 years, 8 months ago (2012-04-11 03:54:58 UTC) #3

Change committed as 131717

Expand Messages | Collapse Messages