Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 9969146: Fix rewriter to not treat throw as an expression. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger
Modified:
8 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix rewriter to not treat throw as an expression. Now we can correctly optimize top level code that contains a throw (or return) as it's last statement. R=ulan@chromium.org BUG=v8:2054 TEST=mjsunit/regress/regress-2054 Committed: https://code.google.com/p/v8/source/detail?r=11224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-2054.js View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 8 months ago (2012-04-04 09:26:53 UTC) #1
ulan
8 years, 8 months ago (2012-04-04 13:36:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698