Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 9969140: Merge 113095 - [chromium] Switch touchpad fling curve physics to absolute (not scaled) curve. (Closed)

Created:
8 years, 8 months ago by jamesr
Modified:
8 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 113095 - [chromium] Switch touchpad fling curve physics to absolute (not scaled) curve. https://bugs.webkit.org/show_bug.cgi?id=83061 Reviewed by James Robinson. Source/WebCore: Revised existing unit tests. Use an absolute curve for touchpad fling. Here we identify the location on the curve corresponding to the initial fling velocity, and "jump in" at that point. Avoids issues around time/magnitude scaling present in previous implementation, and gives better feel to fling animation. * platform/TouchpadFlingPlatformGestureCurve.cpp: (WebCore): (WebCore::TouchpadFlingPlatformGestureCurve::create): (WebCore::position): (WebCore::velocity): (WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve): (WebCore::TouchpadFlingPlatformGestureCurve::apply): * platform/TouchpadFlingPlatformGestureCurve.h: (TouchpadFlingPlatformGestureCurve): Source/WebKit/chromium: * tests/PlatformGestureCurveTest.cpp: TBR=wjmaclean@chromium.org BUG=121824 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+991 lines, -36 lines) Patch
M Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h View 2 chunks +9 lines, -6 lines 0 comments Download
M Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp View 1 chunk +85 lines, -21 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +891 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 8 months ago (2012-04-04 02:55:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698