Set the TZ env to get the UTC-ms since epoch.

runtime/vm/os_linux.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/os.h"
 
 #include <errno.h>
 #include <limits.h>
 #include <time.h>
 #include <sys/resource.h>
 #include <sys/time.h>
 #include <sys/types.h>
 #include <unistd.h>
 
 #include "platform/utils.h"
 #include "vm/isolate.h"
+#include "vm/thread.h"

[Ivan Posva, 2012/04/11 12:01:24]

Please only include what you need.

[floitsch, 2012/04/11 12:10:21]

Done.

 
 namespace dart {
 
 bool OS::BreakDownSecondsSinceEpoch(time_t seconds_since_epoch,
                                     bool in_utc,
                                     BrokenDownDate* result) {
   struct tm tm_result;
   struct tm* error_code;
   if (in_utc) {
     error_code = gmtime_r(&seconds_since_epoch, &tm_result);
   } else {
-    // TODO(floitsch): we should be able to call tzset only once during
-    // initialization.
     tzset();  // Make sure the libc knows about the local zone.
     error_code = localtime_r(&seconds_since_epoch, &tm_result);
   }
   result->year = tm_result.tm_year;
   result->month= tm_result.tm_mon;
   result->day = tm_result.tm_mday;
   result->hours = tm_result.tm_hour;
   result->minutes = tm_result.tm_min;
   result->seconds = tm_result.tm_sec;
   return error_code != NULL;
 }
 
 
+// TODO(floitsch): cache utc offset.

[Ivan Posva, 2012/04/11 12:01:24]

If you cache how long are you willing to cache the value? If the UTC offset of
the machine changes, should this keep track or not?

[floitsch, 2012/04/11 12:10:21]

I would do the same as V8. Changed comment to include a reference to V8.

+static int UtcOffsetInSeconds(time_t seconds_since_epoch) {
+  struct tm t;
+  struct tm* error_code = localtime_r(&seconds_since_epoch, &t);
+  ASSERT(error_code != NULL);
+  return t.tm_gmtoff;
+}
+
+
 bool OS::BrokenDownToSecondsSinceEpoch(
     const BrokenDownDate& broken_down, bool in_utc, time_t* result) {
   struct tm tm_broken_down;
   // mktime takes the years since 1900.
   tm_broken_down.tm_year = broken_down.year;
   tm_broken_down.tm_mon = broken_down.month;
   tm_broken_down.tm_mday = broken_down.day;
   tm_broken_down.tm_hour = broken_down.hours;
   tm_broken_down.tm_min = broken_down.minutes;
   tm_broken_down.tm_sec = broken_down.seconds;
   // Set wday to an impossible day, so that we can catch bad input.
   tm_broken_down.tm_wday = -1;
   // Make sure the libc knows about the local zone.
-  // In case of 'in_utc' this call is mainly for multi-threading issues. If
-  // another thread uses a time-function it will set the timezone. The timezone
-  // adjustement below would then not work anymore.
   // TODO(floitsch): we should be able to call tzset only once during
   // initialization.
   tzset();
-  if (in_utc) {
-    // Disable daylight saving in utc mode.
-    tm_broken_down.tm_isdst = 0;
-    // mktime assumes that the given date is local time zone.
-    *result = mktime(&tm_broken_down);
-    // Remove the timezone.
-    *result -= timezone;
-  } else {
-    // Let libc figure out if daylight saving is active.
-    tm_broken_down.tm_isdst = -1;
-    *result = mktime(&tm_broken_down);
-  }
+  // Let libc figure out if daylight saving is active.
+  tm_broken_down.tm_isdst = -1;
+  *result = mktime(&tm_broken_down);
   if ((*result == -1) && (tm_broken_down.tm_wday == -1)) {
     return false;
   }
+  if (in_utc) {
+    *result += UtcOffsetInSeconds(*result);
+  }
   return true;
 }
 
 
 int64_t OS::GetCurrentTimeMillis() {
   return GetCurrentTimeMicros() / 1000;
 }
 
 
 int64_t OS::GetCurrentTimeMicros() {
@@ skipping 133 matching lines @@
 void OS::Abort() {
   abort();
 }
 
 
 void OS::Exit(int code) {
   exit(code);
 }
 
 }  // namespace dart