Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9969080: Remove TOOLKIT_USES_GTK (Closed)

Created:
8 years, 8 months ago by oshima
Modified:
6 years, 2 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dhollowa+watch_chromium.org, amit, mihaip+watch_chromium.org, dcheng, ajwong+watch_chromium.org, dcaiafa+watch_chromium.org, ncarter (slow), jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Andrei, tim (not reviewing), Avi (use Gerrit), jennb, creis+watch_chromium.org, derat+watch_chromium.org, jonathan.backer, wez+watch_chromium.org, Raghu Simha, sanjeevr, penghuang+watch_chromium.org, jianli, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Dmitry Lomov (no reviews), akalin, Ian Vollick, Dmitry Titov, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, rdsmith+dwatch_chromium.org, alexeypa+watch_chromium.org, James Su, jshin+watch_chromium.org
Visibility:
Public.

Description

Remove TOOLKIT_USES_GTK and consolidate it into TOOLKIT_GTK Add gtk dependency to base.gyp for android host_os="linux" case BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130784

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add gtk dependency to android linux host #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -296 lines) Patch
M base/base.gypi View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M base/i18n/rtl.cc View 1 2 chunks +1 line, -10 lines 0 comments Download
M base/message_loop.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M base/message_pump_glib_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/nix/mime_util_xdg.h View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/mime_util_xdg.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/defaults.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/icon_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/jankometer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tests/ui_gfx_image_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/bookmark_sub_menu_model.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/feature_startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/plugin_process_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/keyboard_listener.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 3 chunks +3 lines, -7 lines 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_drag_dest_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/utility/utility_thread_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/demos/framework/main_exe.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/native/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/tools/shader_bench/shader_bench.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/simple_host_process.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/canvas_paint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld/base/build_config.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/base/clipboard/clipboard_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/keycodes/keyboard_code_conversion_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/events_x.cc View 1 4 chunks +1 line, -16 lines 0 comments Download
M ui/base/x/x11_util.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/compositor/test/test_compositor_host_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/image/image.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/native_widget_types.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/pango_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/platform_font_pango.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/rect.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/rect.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webcursor.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webcursor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (3 generated)
oshima
bluach, can you review android change in base/base.gyp? I need to add this in order ...
8 years, 8 months ago (2012-04-03 22:56:29 UTC) #1
oshima
+erg as he needs to review this too.
8 years, 8 months ago (2012-04-03 22:59:54 UTC) #2
Jamie
remoting lgtm
8 years, 8 months ago (2012-04-03 23:02:35 UTC) #3
Emmanuel Saint-loubert-Bié
Nice. LHTM
8 years, 8 months ago (2012-04-03 23:12:09 UTC) #4
Emmanuel Saint-loubert-Bié
On 2012/04/03 23:12:09, Emmanuel Saint-loubert wrote: > Nice. LHTM => LGTM
8 years, 8 months ago (2012-04-03 23:12:46 UTC) #5
Elliot Glaysher
lgtm
8 years, 8 months ago (2012-04-03 23:14:52 UTC) #6
bulach
android: lgtm thanks!
8 years, 8 months ago (2012-04-04 09:57:36 UTC) #7
sky
LGTM
8 years, 8 months ago (2012-04-04 15:05:57 UTC) #8
oshima
requesting OWNERS approval darin -> content/, base/, webkit/ piman -> gpu scherkus -> media reed1 ...
8 years, 8 months ago (2012-04-04 15:38:13 UTC) #9
scherkus (not reviewing)
media lgtm
8 years, 8 months ago (2012-04-04 17:45:37 UTC) #10
piman
gpu LGTM
8 years, 8 months ago (2012-04-04 18:06:20 UTC) #11
darin (slow to review)
LGTM
8 years, 8 months ago (2012-04-04 20:17:01 UTC) #12
oshima
akalin, can you approve changes in chrome/browser/sync ? Thanks,
8 years, 8 months ago (2012-04-04 21:28:42 UTC) #13
oshima
8 years, 8 months ago (2012-04-04 23:52:39 UTC) #14
lipalani1
LGTM for the 3 files under sync.
8 years, 8 months ago (2012-04-04 23:54:17 UTC) #15
peerless23940
lgtm
6 years, 3 months ago (2014-09-22 09:58:42 UTC) #18
peerless23940
lgtm
6 years, 3 months ago (2014-09-22 09:58:43 UTC) #20
peerless23940
lgtm
6 years, 3 months ago (2014-09-22 09:58:44 UTC) #21
peerless23940
lgtm
6 years, 3 months ago (2014-09-22 09:58:47 UTC) #22
peerless23940
6 years, 2 months ago (2014-10-06 09:50:38 UTC) #23 
Restore
On Sep 22, 2014 2:58 AM, <peerless23940@gmail.com> wrote:

> lgtm
>
>
>
> https://chromiumcodereview.appspot.com/9969080/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698