Issue 9969047: Remove suppression which is incorrect after recent changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969047: Remove suppression which is incorrect after recent changes. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove suppression which is incorrect after recent changes. Committed: https://code.google.com/p/dart/source/detail?r=6121

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	client/tests/client/client.status	View		1 chunk	+0 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

Emily, I don't know if former naming still works. If it does, I should adjust ...

8 years, 8 months ago (2012-04-02 09:42:45 UTC) #1

Emily Fortuna

8 years, 8 months ago (2012-04-02 20:34:07 UTC) #2

the old (component) naming system doesn't work anymore. That must have been a
part of a status file I missed when I did the conversion. Do you actually want
to remove that failure? I listed how you specify it now with the new change. 

Other than deciding on that, lgtm!

https://chromiumcodereview.appspot.com/9969047/diff/1/client/tests/client/cli...
File client/tests/client/client.status (left):

https://chromiumcodereview.appspot.com/9969047/diff/1/client/tests/client/cli...
client/tests/client/client.status:20: [ $component == dartium && $system ==
windows ]
[ $compiler == none && $runtime == drt && $system == windows ] ?

Expand Messages | Collapse Messages