Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 9969006: Code cleanup for speculative type optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 6027)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -856,7 +856,7 @@
bool useGvn() => getFlag(FLAG_USE_GVN);
void setUseGvn() { setFlag(FLAG_USE_GVN); }
- // Does this node pNotentially affect control flow.
Lasse Reichstein Nielsen 2012/03/30 12:41:09 Oh, drat. Maybe I should reenable window autofocus
+ // Does this node potentially affect control flow.
bool isControlFlow() => false;
bool isArray() => type.isArray();
@@ -870,23 +870,6 @@
// Compute the type of the instruction.
HType computeType() => HType.UNKNOWN;
- HType computeDesiredType() {
- HType candidateType = HType.UNKNOWN;
- for (final user in usedBy) {
- HType desiredType = user.computeDesiredInputType(this);
- if (candidateType.isUnknown()) {
- candidateType = desiredType;
- } else if (!type.isUnknown() && candidateType != desiredType) {
- candidateType = candidateType.combine(desiredType);
- if (!candidateType.isKnown()) {
- candidateType = HType.UNKNOWN;
- break;
- }
- }
- }
- return candidateType;
- }
-
HType computeDesiredInputType(HInstruction input) => HType.UNKNOWN;
// Returns whether the instruction does produce the type it claims.
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/types.dart » ('j') | lib/compiler/implementation/ssa/types.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698