Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 9968120: Merge 112992 - Web Inspector: "Pause on start" doesn't change checked state in workers panel (Closed)

Created:
8 years, 8 months ago by pfeldman
Modified:
8 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112992 - Web Inspector: "Pause on start" doesn't change checked state in workers panel https://bugs.webkit.org/show_bug.cgi?id=82908 Reviewed by Yury Semikhatsky. This change partially reverts logic that was introduced with r111551: preventDefault was called beside each stopPropagation. As a result, default checkbox handler was not working. Event.prototype.consume now receives preventDefault parameter that controls whether default action should be prevented. * inspector/front-end/AdvancedSearchController.js: (WebInspector.SearchView.prototype._onKeyDown): * inspector/front-end/CSSSelectorProfileView.js: * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleGroup.prototype._titleClicked): * inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._keyDown): * inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): * inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid): (WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging): * inspector/front-end/Dialog.js: (WebInspector.Dialog.prototype._onKeyDown): * inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._statusBarDragging): * inspector/front-end/Object.js: (WebInspector.Event.prototype.consume): * inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown): * inspector/front-end/ProfileView.js: * inspector/front-end/SearchController.js: (WebInspector.SearchController.prototype._onKeyDown): * inspector/front-end/SoftContextMenu.js: (.WebInspector.SoftContextMenu.prototype.show): (.WebInspector.SoftContextMenu.prototype._menuItemMouseDown): (.WebInspector.SoftContextMenu.prototype._menuKeyDown): (.WebInspector.SoftContextMenu.prototype._discardMenu): * inspector/front-end/Spectrum.js: (WebInspector.Spectrum.draggable.consume): (WebInspector.Spectrum.prototype._onKeyDown): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.muteEventListener): (WebInspector.StylesSidebarPane): (WebInspector.StylePropertiesSection.prototype._handleSelectorClick): (WebInspector.StylePropertyTreeElement.prototype.updateTitle.): (WebInspector.StylePropertyTreeElement.prototype): * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.onKeyDown): (WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler): (WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown): * inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleKeyDown): * inspector/front-end/UIUtils.js: (WebInspector.startEditing): * inspector/front-end/inspector.js: (WebInspector.documentKeyDown): * inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyPress): (TreeOutline.prototype._treeKeyDown): (TreeOutline.prototype._searchInputKeyDown): (TreeElement.prototype.selectOnMouseDown): * inspector/front-end/utilities.js: (Event.prototype.consume): TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -47 lines) Patch
M Source/WebCore/inspector/front-end/AdvancedSearchController.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/CSSSelectorProfileView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/ConsoleView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/DataGrid.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/DatabaseQueryView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/DetailedHeapshotView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/Drawer.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/Object.js View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/ObjectPropertiesSection.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/ProfileView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/SearchController.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/SoftContextMenu.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/front-end/Spectrum.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/StylesSidebarPane.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/front-end/TextPrompt.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/front-end/TextViewer.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/UIUtils.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/inspector.js View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/WebCore/inspector/front-end/treeoutline.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/front-end/utilities.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 8 months ago (2012-04-04 09:01:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698