Addition of GL_CHROMIUM_copy_texture extension.

gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h

Index: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
===================================================================
--- gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h	(revision 0)
+++ gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h	(revision 0)
@@ -0,0 +1,41 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
+#define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
+
+#include "gpu/command_buffer/service/gl_utils.h"
+
+// This class encapsulates the resources required to implement the
+// GL_CHROMIUM_copy_texture extension.  The copy operation is performed
+// via a blit to a framebuffer object.
+class CopyTextureCHROMIUMResourceManager {
+ public:
+  CopyTextureCHROMIUMResourceManager() : initialized_(false) {}
+
+  void Initialize();
+  void Destroy();
+
+  void DoCopyTexture(GLenum target, GLuint source_id, GLuint dest_id,
+                     GLint level, bool flip_y, bool premultiply_alpha);
+
+  // The attributes used during invocation of the extension.
+  static const GLuint kVertexPositionAttrib = 0;
+  static const GLuint kVertexTextureAttrib = 1;

[greggman, 2012/04/17 04:58:06]

Do you mind adding

COMPILE_ASSERT(
    kVertexPositionAttrib == 0u ||
    kVertexTextureAttrib == 0u,
    CopyTexture_One_of_these_attribs_must_be_0);

Just so someone doesn't change them to 1 and 2 which will fail on Desktop GL.

[Jeff Timanus, 2012/04/18 14:59:08]

Done.

Why would they fail on DesktopGL?  Are 1 and 2 the values for the default
attribs in desktop GL?  The use of value 1 is permitted as it is?

[greggman, 2012/04/19 00:39:39]

It would fail on Desktop GL because, though undocumented, desktopGL doesn't work
unless you use Attrib 0. It's a bug in all desktopGLs. We work around it in the
command buffer code but this code is running below the command buffer and so
would run into the bug.

+
+ private:
+  bool initialized_;
+
+  static const int kNumPrograms = 4;
+  GLuint programs_[kNumPrograms];
+  GLuint buffer_ids_[2];
+  GLuint framebuffer_;
+  GLuint sampler_locations_[kNumPrograms];
+
+  DISALLOW_COPY_AND_ASSIGN(CopyTextureCHROMIUMResourceManager);
+};
+
+#endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
+
+
Property changes on: gpu\command_buffer\service\gles2_cmd_copy_texture_chromium.h
___________________________________________________________________
Added: svn:eol-style
   + LF