Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 9968064: Documenting permissions for OAuth tutorial (Closed)

Created:
8 years, 8 months ago by mkearney
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

This change includes a paragraph on required permissions for extensions that use the OAuth API. I made the same changes in a previous cl (Issue 9298035), which were approved, but then the patch went stale, and I needed to recreate the work. BUG=110560 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150195

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M chrome/common/extensions/docs/static/tut_oauth.html View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/tut_oauth.html View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
commit-bot: I haz the power
No comments yet.
8 years, 8 months ago (2012-04-03 20:45:23 UTC) #1
kathyw
lgtm
8 years, 8 months ago (2012-04-03 20:48:39 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-03 20:48:47 UTC) #3
Mihai Parparita -not on Chrome
LGTM
8 years, 8 months ago (2012-04-03 22:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@google.com/9968064/6002
8 years, 8 months ago (2012-04-03 22:49:12 UTC) #5
commit-bot: I haz the power
Try job failure for 9968064-6002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-03 23:42:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@google.com/9968064/8002
8 years, 8 months ago (2012-04-27 18:13:14 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 8 months ago (2012-04-27 19:42:21 UTC) #8
mkearney
8 years, 8 months ago (2012-04-27 20:59:37 UTC) #9
Aaron,

Can you push this through, assuming the below message is true and it is
safe to do so.

Meggin

On Fri, Apr 27, 2012 at 12:42 PM, <commit-bot@chromium.org> wrote:

> The commit queue went berserk retrying too often for a
> seemingly flaky test. Builder is mac_rel, revision is 134318, job name
> was 9968064-8002 (retry) (retry) (retry) (previous was lost).
>
>
http://codereview.chromium.**org/9968064/<http://codereview.chromium.org/9968...
>

Powered by Google App Engine
This is Rietveld 408576698