Issue 9968058: Cleanup: remove GTK stuff

Issue 9968058: Cleanup: remove GTK stuff (Closed)

Created:
8 years, 8 months ago by oshima

Modified:
8 years, 8 months ago

Reviewers:
sky, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews, tfarina, James Su, ben+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

* removed views debug paint that was used in NativeWidgetGtk. This may be useful on aura, but should probably be in layer/compositor code * removed unnecessary ifdef that were for linux+views+non aura. * updated gtk related descriptions BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130327

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -114 lines)			Patch
M	chrome/browser/chrome_browser_main_extra_parts_views.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/dropdown_bar_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/find_bar_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view.h	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view.cc	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1	3 chunks	+0 lines, -28 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1	1 chunk	+1 line, -11 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/views/controls/menu/menu_runner.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/controls/native/native_view_host.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	ui/views/controls/textfield/textfield.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/controls/textfield/textfield.cc	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	ui/views/examples/example_base.cc	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/views/focus/focus_manager.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/focus/focus_manager_unittest_win.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/ime/input_method.h	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/views/view.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/view.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/views/widget/widget.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1	3 chunks	+2 lines, -19 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9968058/5023

8 years, 8 months ago (2012-04-03 00:09:08 UTC) #6

commit-bot: I haz the power

8 years, 8 months ago (2012-04-03 01:54:28 UTC) #7

Try job failure for 9968058-5023 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages