Issue 9968056: Properly support shrinking arrays in CopyDictionaryToObjectElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9968056: Properly support shrinking arrays in CopyDictionaryToObjectElements. (Closed)

Created:
8 years, 8 months ago by danno

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly support shrinking arrays in CopyDictionaryToObjectElements. R=mstarzinger@chromium.org BUG=chromium:121407 TEST=test/mjsunit/regress/regress-121407.js Committed: https://code.google.com/p/v8/source/detail?r=11214

Patch Set 1 #

Patch Set 2 : Remove assert #

Patch Set 3 : Extend test case #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -2 lines)			Patch
	M	src/elements.cc	View	1	2 chunks	+8 lines, -2 lines	1 comment	Download
	A	test/mjsunit/regress/regress-121407.js	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 8 months ago (2012-04-03 08:13:18 UTC) #1

LGTM.

https://chromiumcodereview.appspot.com/9968056/diff/2002/src/elements.cc
File src/elements.cc (right):

https://chromiumcodereview.appspot.com/9968056/diff/2002/src/elements.cc#newc...
src/elements.cc:206: if (to_start + copy_size > to_length) {
I suspect that without the cast this will lead to warnings on VSC++. But I am
unsure, so I would just let it run through the buildbots.

Expand Messages | Collapse Messages