Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2350)

Unified Diff: chrome/browser/webdata/keyword_table_unittest.cc

Issue 9968016: Move the URL string from TemplateURLRef onto the owning TemplateURL. This will make it easier to m… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/keyword_table.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/keyword_table_unittest.cc
===================================================================
--- chrome/browser/webdata/keyword_table_unittest.cc (revision 130285)
+++ chrome/browser/webdata/keyword_table_unittest.cc (working copy)
@@ -100,11 +100,8 @@
EXPECT_EQ(keyword.created_by_policy(), restored_keyword->created_by_policy());
EXPECT_EQ(keyword.usage_count(), restored_keyword->usage_count());
EXPECT_EQ(keyword.prepopulate_id(), restored_keyword->prepopulate_id());
- ASSERT_TRUE(restored_keyword->url());
- EXPECT_EQ(keyword.url()->url(), restored_keyword->url()->url());
- ASSERT_TRUE(restored_keyword->instant_url());
- EXPECT_EQ(keyword.instant_url()->url(),
- restored_keyword->instant_url()->url());
+ EXPECT_EQ(keyword.url(), restored_keyword->url());
+ EXPECT_EQ(keyword.instant_url(), restored_keyword->instant_url());
EXPECT_EQ(keyword.favicon_url(), restored_keyword->favicon_url());
EXPECT_TRUE(keyword_table->RemoveKeyword(restored_keyword->id()));
@@ -181,13 +178,10 @@
EXPECT_EQ(keyword.short_name(), backup_url->short_name());
EXPECT_EQ(keyword.keyword(), backup_url->keyword());
EXPECT_EQ(keyword.favicon_url(), backup_url->favicon_url());
- ASSERT_TRUE(backup_url->url());
- EXPECT_EQ(keyword.url()->url(), backup_url->url()->url());
+ EXPECT_EQ(keyword.url(), backup_url->url());
EXPECT_EQ(keyword.safe_for_autoreplace(), backup_url->safe_for_autoreplace());
EXPECT_EQ(keyword.show_in_default_list(), backup_url->show_in_default_list());
- ASSERT_TRUE(backup_url->suggestions_url());
- EXPECT_EQ(keyword.suggestions_url()->url(),
- backup_url->suggestions_url()->url());
+ EXPECT_EQ(keyword.suggestions_url(), backup_url->suggestions_url());
EXPECT_FALSE(keyword_table->DidDefaultSearchProviderChange());
// Change the actual setting.
@@ -201,13 +195,10 @@
EXPECT_EQ(keyword.short_name(), backup_url->short_name());
EXPECT_EQ(keyword.keyword(), backup_url->keyword());
EXPECT_EQ(keyword.favicon_url(), backup_url->favicon_url());
- ASSERT_TRUE(backup_url->url());
- EXPECT_EQ(keyword.url()->url(), backup_url->url()->url());
+ EXPECT_EQ(keyword.url(), backup_url->url());
EXPECT_EQ(keyword.safe_for_autoreplace(), backup_url->safe_for_autoreplace());
EXPECT_EQ(keyword.show_in_default_list(), backup_url->show_in_default_list());
- ASSERT_TRUE(backup_url->suggestions_url());
- EXPECT_EQ(keyword.suggestions_url()->url(),
- backup_url->suggestions_url()->url());
+ EXPECT_EQ(keyword.suggestions_url(), backup_url->suggestions_url());
EXPECT_TRUE(keyword_table->DidDefaultSearchProviderChange());
// Change the backup.
@@ -243,13 +234,10 @@
EXPECT_EQ(keyword.short_name(), backup_url->short_name());
EXPECT_EQ(keyword.keyword(), backup_url->keyword());
EXPECT_EQ(keyword.favicon_url(), backup_url->favicon_url());
- ASSERT_TRUE(backup_url->url());
- EXPECT_EQ(keyword.url()->url(), backup_url->url()->url());
+ EXPECT_EQ(keyword.url(), backup_url->url());
EXPECT_EQ(keyword.safe_for_autoreplace(), backup_url->safe_for_autoreplace());
EXPECT_EQ(keyword.show_in_default_list(), backup_url->show_in_default_list());
- ASSERT_TRUE(backup_url->suggestions_url());
- EXPECT_EQ(keyword.suggestions_url()->url(),
- backup_url->suggestions_url()->url());
+ EXPECT_EQ(keyword.suggestions_url(), backup_url->suggestions_url());
EXPECT_TRUE(keyword_table->DidDefaultSearchProviderChange());
// Change keywords backup.
@@ -387,13 +375,9 @@
EXPECT_EQ(keyword.input_encodings(), restored_keyword->input_encodings());
EXPECT_EQ(keyword.id(), restored_keyword->id());
EXPECT_EQ(keyword.prepopulate_id(), restored_keyword->prepopulate_id());
- ASSERT_TRUE(restored_keyword->suggestions_url());
- EXPECT_EQ(keyword.suggestions_url()->url(),
- restored_keyword->suggestions_url()->url());
- ASSERT_TRUE(restored_keyword->instant_url());
+ EXPECT_EQ(keyword.suggestions_url(), restored_keyword->suggestions_url());
EXPECT_EQ(keyword.favicon_url(), restored_keyword->favicon_url());
- EXPECT_EQ(keyword.instant_url()->url(),
- restored_keyword->instant_url()->url());
+ EXPECT_EQ(keyword.instant_url(), restored_keyword->instant_url());
STLDeleteElements(&keywords);
}
« no previous file with comments | « chrome/browser/webdata/keyword_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698