Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/ui/search_engines/template_url_table_model.cc

Issue 9968016: Move the URL string from TemplateURLRef onto the owning TemplateURL. This will make it easier to m… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search_engines/template_url_table_model.cc
===================================================================
--- chrome/browser/ui/search_engines/template_url_table_model.cc (revision 130285)
+++ chrome/browser/ui/search_engines/template_url_table_model.cc (working copy)
@@ -82,8 +82,8 @@
GURL favicon_url = template_url()->favicon_url();
if (!favicon_url.is_valid()) {
// The favicon url isn't always set. Guess at one here.
- if (template_url_->url() && template_url_->url()->IsValid()) {
- GURL url(template_url_->url()->url());
+ if (template_url_->url_ref().IsValid()) {
+ GURL url(template_url_->url());
if (url.is_valid())
favicon_url = TemplateURL::GenerateFaviconURL(url);
}

Powered by Google App Engine
This is Rietveld 408576698