Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: chrome/browser/protector/default_search_provider_change_browsertest.cc

Issue 9968016: Move the URL string from TemplateURLRef onto the owning TemplateURL. This will make it easier to m… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/protector/default_search_provider_change.cc ('k') | chrome/browser/protector/histograms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/protector/default_search_provider_change_browsertest.cc
===================================================================
--- chrome/browser/protector/default_search_provider_change_browsertest.cc (revision 130285)
+++ chrome/browser/protector/default_search_provider_change_browsertest.cc (working copy)
@@ -79,7 +79,7 @@
turl_service_->GetTemplateURLs();
for (TemplateURLService::TemplateURLVector::const_iterator
it = urls.begin(); it != urls.end(); ++it) {
- if ((*it)->url()->url() == search_url)
+ if ((*it)->url() == search_url)
return *it;
}
return NULL;
@@ -257,7 +257,7 @@
AddAndSetDefault(current_url);
// Prepopulated default search must exist.
- ASSERT_TRUE(FindTemplateURL(prepopulated_url_->url()->url()));
+ ASSERT_TRUE(FindTemplateURL(prepopulated_url_->url()));
scoped_ptr<BaseSettingChange> change(
CreateDefaultSearchProviderChange(current_url, NULL));
@@ -265,7 +265,7 @@
ASSERT_TRUE(change->Init(browser()->profile()));
// Verify that the prepopulated default search is active.
- EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()->url()),
+ EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()),
turl_service_->GetDefaultSearchProvider());
// Verify histograms.
@@ -286,7 +286,7 @@
// Verify that search engine settings are opened by Discard.
ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
change->Discard(browser());
- EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()->url()),
+ EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()),
turl_service_->GetDefaultSearchProvider());
// Verify that Apply switches back to |current_url|.
@@ -310,7 +310,7 @@
AddAndSetDefault(current_url);
const TemplateURL* prepopulated_default =
- FindTemplateURL(prepopulated_url_->url()->url());
+ FindTemplateURL(prepopulated_url_->url());
// Prepopulated default search must exist, remove it.
ASSERT_TRUE(prepopulated_default);
turl_service_->Remove(prepopulated_default);
@@ -321,7 +321,7 @@
ASSERT_TRUE(change->Init(browser()->profile()));
// Verify that the prepopulated default search is active.
- EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()->url()),
+ EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()),
turl_service_->GetDefaultSearchProvider());
// Verify histograms.
@@ -344,7 +344,7 @@
// Verify that search engine settings are opened by Discard.
ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
change->Discard(browser());
- EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()->url()),
+ EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()),
turl_service_->GetDefaultSearchProvider());
// Verify that Apply switches back to |current_url|.
@@ -410,7 +410,7 @@
ASSERT_TRUE(change->Init(browser()->profile()));
// Verify that the prepopulated default search is active.
- EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()->url()),
+ EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()),
turl_service_->GetDefaultSearchProvider());
// Verify histograms.
@@ -430,7 +430,7 @@
// Verify that search engine settings are opened by Discard.
ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
change->Discard(browser());
- EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()->url()),
+ EXPECT_EQ(FindTemplateURL(prepopulated_url_->url()),
turl_service_->GetDefaultSearchProvider());
}
@@ -444,7 +444,7 @@
// Verify that current search provider is same as the prepopulated default.
ASSERT_TRUE(current_url);
- ASSERT_EQ(current_url, FindTemplateURL(prepopulated_url_->url()->url()));
+ ASSERT_EQ(current_url, FindTemplateURL(prepopulated_url_->url()));
scoped_ptr<BaseSettingChange> change(
CreateDefaultSearchProviderChange(current_url, NULL));
« no previous file with comments | « chrome/browser/protector/default_search_provider_change.cc ('k') | chrome/browser/protector/histograms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698