Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: chrome/browser/instant/instant_controller.cc

Issue 9968016: Move the URL string from TemplateURLRef onto the owning TemplateURL. This will make it easier to m… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_controller.cc
===================================================================
--- chrome/browser/instant/instant_controller.cc (revision 129864)
+++ chrome/browser/instant/instant_controller.cc (working copy)
@@ -529,8 +529,8 @@
// Returns true if |template_url| is a valid TemplateURL for use by instant.
bool InstantController::IsValidInstantTemplateURL(
const TemplateURL* template_url) {
- return template_url && template_url->instant_url() && template_url->id() &&
sky 2012/03/30 22:00:29 I think we should keep this id() check. During sta
- template_url->instant_url()->SupportsReplacement() &&
+ return template_url &&
+ template_url->instant_url_ref().SupportsReplacement() &&
!IsBlacklistedFromInstant(template_url->id());
}

Powered by Google App Engine
This is Rietveld 408576698