Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 9968013: Add policy switch for location reporting and decode all policies in device_policy_cache. (Closed)

Created:
8 years, 8 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add policy switch for location reporting and decode all policies in device_policy_cache. BUG=chromium-os:18710 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129923

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix doc string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M chrome/app/policy/policy_templates.json View 1 3 chunks +34 lines, -1 line 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mattias Nissler (ping if slow)
Whoever reads this, can I haz stamp?
8 years, 8 months ago (2012-03-30 15:24:07 UTC) #1
Joao da Silva
lgtm. Please consider the comments inline. http://codereview.chromium.org/9968013/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/9968013/diff/1/chrome/app/policy/policy_templates.json#newcode2577 chrome/app/policy/policy_templates.json:2577: Specifies the prefix ...
8 years, 8 months ago (2012-03-30 15:43:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/9968013/5001
8 years, 8 months ago (2012-03-30 19:15:24 UTC) #3
commit-bot: I haz the power
Presubmit check for 9968013-5001 failed and returned exit status 1. Could not locate pyautolib shared ...
8 years, 8 months ago (2012-03-30 19:15:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/9968013/5001
8 years, 8 months ago (2012-03-30 19:19:05 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-03-30 19:19:08 UTC) #6
Presubmit check for 9968013-5001 failed and returned exit status 1.

Could not locate pyautolib shared libraries.  Did you build?
  Documentation: http://dev.chromium.org/developers/testing/pyauto
Cannot import pyauto from
['/mnt/data/b/commit-queue/workdir/chromium/chrome/test/functional',
'/mnt/data/b/commit-queue', '/mnt/data/b/commit-queue/verification',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/pip-1.0.2-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/setuptools-0.6c12dev_r88846-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/mercurial-2.0.2-py2.6-linux-x86_64.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/mechanize-0.2.5-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/pylint-0.25.1-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/logilab_astng-0.23.1-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/logilab_common-0.57.1-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/unittest2-0.5.1-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/nose-1.1.2-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/NoseGAE-0.2.0-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/WebTest-1.3.3-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages/WebOb-1.2b3-py2.6.egg',
'/home/chrome-bot/python2.6/lib/python2.6',
'/home/chrome-bot/python2.6/lib/python2.6/plat-linux2',
'/home/chrome-bot/python2.6/lib/python2.6/lib-tk',
'/home/chrome-bot/python2.6/lib/python2.6/lib-old',
'/home/chrome-bot/python2.6/lib/python2.6/lib-dynload', '/usr/lib/python2.6',
'/usr/lib64/python2.6', '/usr/lib/python2.6/plat-linux2',
'/usr/lib/python2.6/lib-tk', '/usr/lib64/python2.6/lib-tk',
'/home/chrome-bot/python2.6/lib/python2.6/site-packages', '/b/depot_tools',
'/mnt/data/b/commit-queue/workdir/chromium/chrome/test/functional/../pyautolib',
'/mnt/data/b/commit-queue/workdir/chromium/out/Debug',
'/mnt/data/b/commit-queue/workdir/chromium/out/Release',
'/mnt/data/b/commit-queue/workdir/chromium/sconsbuild/Debug',
'/mnt/data/b/commit-queue/workdir/chromium/sconsbuild/Release',
'/mnt/data/b/commit-queue/workdir/chromium/chrome/test/pyautolib',
'/mnt/data/b/commit-queue/workdir/chromium/third_party',
'/mnt/data/b/commit-queue/workdir/chromium/third_party/webdriver/pylib']
Running presubmit commit checks ...
Finished checking
/mnt/data/b/commit-queue/workdir/chromium/chrome/app/policy/policy_templates.json.
0 errors, 0 warnings.
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 43, in
<module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1266, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1114, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1031, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 95, in CheckChangeOnCommit
  File "<string>", line 86, in _CommonChecks
  File "<string>", line 61, in _CheckPolicyPyauto
  File
"/mnt/data/b/commit-queue/workdir/chromium/chrome/test/functional/policy_test_cases.py",
line 9, in <module>
    import pyauto_functional  # must come before pyauto.
  File
"/mnt/data/b/commit-queue/workdir/chromium/chrome/test/functional/pyauto_functional.py",
line 84, in <module>
    import pyauto
  File
"/mnt/data/b/commit-queue/workdir/chromium/chrome/test/functional/../pyautolib/pyauto.py",
line 68, in <module>
    import pyautolib
ImportError: No module named pyautolib

Powered by Google App Engine
This is Rietveld 408576698