chrome/browser/protector/settings_change_global_error.cc - Issue 9968007: [protector] Support for collapsing multiple changes into a single one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/protector/settings_change_global_error.cc

Issue 9968007: [protector] Support for collapsing multiple changes into a single one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/protector/settings_change_global_error.cc

diff --git a/chrome/browser/protector/settings_change_global_error.cc b/chrome/browser/protector/settings_change_global_error.cc

index a51103b9102069c8d894fec1106dd256af96f642..9a18a04cd5b7f0aa53ef38614c3a32d3816884fe 100644

--- a/chrome/browser/protector/settings_change_global_error.cc

+++ b/chrome/browser/protector/settings_change_global_error.cc

@@ -165,6 +165,10 @@ string16 SettingsChangeGlobalError::GetBubbleViewCancelButtonLabel() {

}

void SettingsChangeGlobalError::OnBubbleViewDidClose(Browser* browser) {

+ // The bubble may be closed as the result of RemoveFromProfile call when

+ // merging this error with another one.

+ if (!profile_)

+ return;

if (!closed_by_button_) {

BrowserThread::PostDelayedTask(

BrowserThread::UI, FROM_HERE,