| Index: chrome/browser/protector/default_search_provider_change_browsertest.cc
|
| diff --git a/chrome/browser/protector/default_search_provider_change_browsertest.cc b/chrome/browser/protector/default_search_provider_change_browsertest.cc
|
| index 4dae17c83ed55cc813bf5987eae83325ebd8b97b..1db31f13282c55929bb7fa3ff0947d8b616b5c5d 100644
|
| --- a/chrome/browser/protector/default_search_provider_change_browsertest.cc
|
| +++ b/chrome/browser/protector/default_search_provider_change_browsertest.cc
|
| @@ -33,12 +33,18 @@ namespace {
|
|
|
| const string16 example_info = ASCIIToUTF16("Example.info");
|
| const string16 example_info_long = ASCIIToUTF16("ExampleSearchEngine.info");
|
| -const std::string http_example_info = "http://example.info/%s";
|
| +const std::string http_example_info = "http://example.info/?q={searchTerms}";
|
| +const std::string example_info_domain = "example.info";
|
| const string16 example_com = ASCIIToUTF16("Example.com");
|
| const string16 example_com_long = ASCIIToUTF16("ExampleSearchEngine.com");
|
| -const std::string http_example_com = "http://example.com/%s";
|
| +const std::string http_example_com = "http://example.com/?q={searchTerms}";
|
| +const std::string example_com_domain = "example.com";
|
| const string16 example_net = ASCIIToUTF16("Example.net");
|
| -const std::string http_example_net = "http://example.net/%s";
|
| +const std::string http_example_net = "http://example.net/?q={searchTerms}";
|
| +const std::string example_domain = "example.net";
|
| +
|
| +const BaseSettingChange::DisplayName kNoDisplayName(
|
| + BaseSettingChange::kDefaultNamePriority, string16());
|
|
|
| // Convenience function.
|
| TemplateURL* MakeTemplateURL(const string16& short_name,
|
| @@ -177,6 +183,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest, BackupValid) {
|
| change->GetApplyButtonText());
|
| EXPECT_EQ(GetKeepSearchButtonText(example_info),
|
| change->GetDiscardButtonText());
|
| + EXPECT_EQ(example_com_domain, change->GetApplyKeyword());
|
| + EXPECT_EQ(example_com, change->GetApplyDisplayName().second);
|
|
|
| // Discard does nothing - backup was already active.
|
| change->Discard(browser());
|
| @@ -219,6 +227,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest, BackupValidLongNames) {
|
| EXPECT_EQ(GetChangeSearchButtonText(example_com),
|
| change->GetApplyButtonText());
|
| EXPECT_EQ(GetKeepSearchButtonText(), change->GetDiscardButtonText());
|
| + EXPECT_EQ(example_com_domain, change->GetApplyKeyword());
|
| + EXPECT_EQ(example_com, change->GetApplyDisplayName().second);
|
| }
|
|
|
| {
|
| @@ -236,6 +246,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest, BackupValidLongNames) {
|
| EXPECT_EQ(GetChangeSearchButtonText(), change->GetApplyButtonText());
|
| EXPECT_EQ(GetKeepSearchButtonText(example_info),
|
| change->GetDiscardButtonText());
|
| + EXPECT_EQ(example_com_domain, change->GetApplyKeyword());
|
| + EXPECT_EQ(kNoDisplayName, change->GetApplyDisplayName());
|
| }
|
| }
|
|
|
| @@ -335,6 +347,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest,
|
| EXPECT_EQ(GetChangeSearchButtonText(example_com),
|
| change->GetApplyButtonText());
|
| EXPECT_EQ(GetOpenSettingsButtonText(), change->GetDiscardButtonText());
|
| + EXPECT_EQ(std::string(), change->GetApplyKeyword());
|
| + EXPECT_EQ(example_com, change->GetApplyDisplayName().second);
|
|
|
| // Verify that search engine settings are opened by Discard.
|
| ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
|
| @@ -378,6 +392,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest,
|
| EXPECT_EQ(GetOpenSettingsButtonText(), change->GetApplyButtonText());
|
| EXPECT_EQ(GetKeepSearchButtonText(example_info),
|
| change->GetDiscardButtonText());
|
| + EXPECT_EQ(std::string(), change->GetApplyKeyword());
|
| + EXPECT_EQ(kNoDisplayName, change->GetApplyDisplayName());
|
|
|
| // Discard does nothing - backup was already active.
|
| change->Discard(browser());
|
| @@ -421,6 +437,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest,
|
| change->GetBubbleMessage());
|
| EXPECT_EQ(string16(), change->GetApplyButtonText());
|
| EXPECT_EQ(GetOpenSettingsButtonText(), change->GetDiscardButtonText());
|
| + EXPECT_EQ(std::string(), change->GetApplyKeyword());
|
| + EXPECT_EQ(kNoDisplayName, change->GetApplyDisplayName());
|
|
|
| // Verify that search engine settings are opened by Discard.
|
| ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
|
| @@ -462,6 +480,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest,
|
| change->GetBubbleMessage());
|
| EXPECT_EQ(string16(), change->GetApplyButtonText());
|
| EXPECT_EQ(GetOpenSettingsButtonText(), change->GetDiscardButtonText());
|
| + EXPECT_EQ(std::string(), change->GetApplyKeyword());
|
| + EXPECT_EQ(current_url->short_name(), change->GetApplyDisplayName().second);
|
|
|
| // Verify that search engine settings are opened by Discard.
|
| ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
|
| @@ -526,6 +546,8 @@ IN_PROC_BROWSER_TEST_F(DefaultSearchProviderChangeTest,
|
| EXPECT_EQ(GetOpenSettingsButtonText(), change->GetApplyButtonText());
|
| EXPECT_EQ(GetKeepSearchButtonText(example_info),
|
| change->GetDiscardButtonText());
|
| + EXPECT_EQ(std::string(), change->GetApplyKeyword());
|
| + EXPECT_EQ(kNoDisplayName, change->GetApplyDisplayName());
|
|
|
| // Verify that search engine settings are opened by Apply.
|
| ExpectSettingsOpened(chrome::kSearchEnginesSubPage);
|
|
|