chrome/browser/speech/extension_api/tts_extension_api_controller.cc - Issue 9967021: Uses a system-wide notion of isSpeaking in the Mac extension TTS api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api_controller.cc

Issue 9967021: Uses a system-wide notion of isSpeaking in the Mac extension TTS api. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_api_controller.h ('k') | chrome/browser/speech/extension_api/tts_extension_api_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_extension_api_controller.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api_controller.cc b/chrome/browser/speech/extension_api/tts_extension_api_controller.cc

index 47dd5ca82dfb1572a94cd5f5fc508221993cadd2..2989bd9a9c9e0dc6864f3031ef1240af332d7944 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api_controller.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api_controller.cc

@@ -283,8 +283,8 @@ ListValue* ExtensionTtsController::GetVoices(Profile* profile) {

return result_voices;

}

-bool ExtensionTtsController::IsSpeaking() const {

- return current_utterance_ != NULL;

+bool ExtensionTtsController::IsSpeaking() {

+ return current_utterance_ != NULL && GetPlatformImpl()->IsSpeaking();

dmazzoni 2012/04/11 20:44:18 Shouldn't this be || instead of &&

David Tseng 2012/04/11 22:20:47 On 2012/04/11 20:44:18, Dominic Mazzoni wrote: Yo

}

void ExtensionTtsController::FinishCurrentUtterance() {