Issue 9967020: Wrap ninja invocation to include python in path, and set up compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9967020: Wrap ninja invocation to include python in path, and set up compiler (Closed)

Created:
8 years, 8 months ago by scottmg

Modified:
8 years, 8 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Wrap ninja invocation to include python in path, and set up compiler environment before invoking the ninja binary itself (which is moved to a subdirectory). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132239

Patch Set 1 #

Patch Set 2 : tweak wrapper a bit #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
A	ninja.bat	View	1 2 3	1 chunk	+42 lines, -0 lines	0 comments	Download
D	ninja.exe	View		Binary file		0 comments	Download
D	ninja-deplist-helper.exe	View		Binary file		0 comments	Download
A	ninja-win/ninja.exe	View		Binary file		0 comments	Download
A	ninja-win/ninja-deplist-helper.exe	View		Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

not sure if you're concerned, minor addition of wrapper script around ninja exe.

8 years, 8 months ago (2012-04-11 20:45:35 UTC) #1

M-A Ruel

That's kind of sad, oh well. lgtm https://chromiumcodereview.appspot.com/9967020/diff/3001/ninja.bat File ninja.bat (right): https://chromiumcodereview.appspot.com/9967020/diff/3001/ninja.bat#newcode1 ninja.bat:1: @echo off ...

8 years, 8 months ago (2012-04-13 19:00:58 UTC) #2

scottmg

8 years, 8 months ago (2012-04-13 19:35:35 UTC) #3

http://chromiumcodereview.appspot.com/9967020/diff/3001/ninja.bat
File ninja.bat (right):

http://chromiumcodereview.appspot.com/9967020/diff/3001/ninja.bat#newcode1
ninja.bat:1: @echo off
On 2012/04/13 19:00:58, Marc-Antoine Ruel wrote:
> Still keep a copyright header after the @echo off.

Done.

http://chromiumcodereview.appspot.com/9967020/diff/3001/ninja.bat#newcode25
ninja.bat:25: goto script_exit
On 2012/04/13 19:00:58, Marc-Antoine Ruel wrote:
> goto :EOF
> would work fine.

Done.

Expand Messages | Collapse Messages