Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: src/trusted/validator_ragel/unreviewed/gen-decoder.cc

Issue 9967015: Revert 8203: Revert 8202 - Add ragel decoder/validator to SCONS (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_ragel/unreviewed/gen-decoder.cc
===================================================================
--- src/trusted/validator_ragel/unreviewed/gen-decoder.cc (revision 8148)
+++ src/trusted/validator_ragel/unreviewed/gen-decoder.cc (working copy)
@@ -18,6 +18,7 @@
#include <tuple>
#include <vector>
+
template <typename T, size_t N>
char (&ArraySizeHelper(T (&array)[N]))[N];
#define arraysize(array) (sizeof(ArraySizeHelper(array)))
@@ -189,7 +190,7 @@
class Instruction {
public:
- static bool check_flag_valid(const std::string &flag) {
+ static void check_flag_valid(const std::string &flag) {
if (all_instruction_flags.find(flag) == all_instruction_flags.end()) {
fprintf(stderr, "%s: unknown flag: '%s'\n",
short_program_name, flag.c_str());
@@ -1189,7 +1190,7 @@
explicit MarkedInstruction(Instruction instruction_) :
Instruction(instruction_),
instruction_class(get_instruction_class(instruction_)),
- opcode_in_modrm(false), opcode_in_imm(false), rex { } {
+ rex { }, opcode_in_modrm(false), opcode_in_imm(false) {
if (has_flag("branch_hint")) {
optional_prefixes.insert("branch_hint");
}
@@ -1548,7 +1549,7 @@
}
bool modrm_memory = false;
bool modrm_register = false;
- char operand_source;
+ char operand_source = ' ';
for (auto operand_it = operands.begin();
operand_it != operands.end(); ++operand_it) {
auto &operand = *operand_it;

Powered by Google App Engine
This is Rietveld 408576698