Issue 9967006: Check host_ is not NULL in isRToL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9967006: Check host_ is not NULL in isRToL. (Closed)

Created:
8 years, 8 months ago by Jamie

Modified:
8 years, 8 months ago

Reviewers:
dmac, Lambros (do not use)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Check host_ is not NULL in isRToL. BUG=122400 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131444

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	remoting/host/disconnect_window_mac.mm	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jamie

isRToL is being called after host_ has been NULLed. I don't know enough about the ...

8 years, 8 months ago (2012-04-09 19:48:31 UTC) #1

Lambros

8 years, 8 months ago (2012-04-09 20:21:13 UTC) #2

On 2012/04/09 19:48:31, Jamie wrote:
> isRToL is being called after host_ has been NULLed. I don't know enough about
> the threading model to know whether or not this check is sufficient to prevent
> the crash, or whether we need locking as well.

I would hope that all the methods on this class are called on the same thread.

lgtm

Expand Messages | Collapse Messages