Catch printf() in CheckSpamLogging

Catch printf() in CheckSpamLogging

R=maruel@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238199

[Nico, 2013-12-02 20:28:39]

lgtm, thanks

[jln (very slow on Chromium), 2013-12-02 20:29:20]

As noted by Nico, my previous change disable the printf check.

Rather than making the regexp even more complicated, I decided to handle the
printf case on its own.

[M-A Ruel, 2013-12-02 21:06:08]

lgtm with cleanup

https://codereview.chromium.org/99653004/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/99653004/diff/1/PRESUBMIT.py#newcode852
PRESUBMIT.py:852: if re.search(r"\bD?LOG_IF\s*\(\s*INFO\s*,", contents):
elif

https://codereview.chromium.org/99653004/diff/1/PRESUBMIT.py#newcode854
PRESUBMIT.py:854: if re.search(r"\bprintf\(", contents):
insert a line to make it clear they are not doing the same thing.

https://codereview.chromium.org/99653004/diff/1/PRESUBMIT.py#newcode856
PRESUBMIT.py:856: if re.search(r"\bfprintf\((stdout|stderr)", contents):
elif

[jln (very slow on Chromium), 2013-12-02 21:38:05]

https://chromiumcodereview.appspot.com/99653004/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/99653004/diff/1/PRESUBMIT.py#newcode852
PRESUBMIT.py:852: if re.search(r"\bD?LOG_IF\s*\(\s*INFO\s*,", contents):
On 2013/12/02 21:06:09, M-A Ruel wrote:
> elif

Done.

https://chromiumcodereview.appspot.com/99653004/diff/1/PRESUBMIT.py#newcode854
PRESUBMIT.py:854: if re.search(r"\bprintf\(", contents):
On 2013/12/02 21:06:09, M-A Ruel wrote:
> insert a line to make it clear they are not doing the same thing.

Done.

https://chromiumcodereview.appspot.com/99653004/diff/1/PRESUBMIT.py#newcode856
PRESUBMIT.py:856: if re.search(r"\bfprintf\((stdout|stderr)", contents):
On 2013/12/02 21:06:09, M-A Ruel wrote:
> elif

Done.

[commit-bot: I haz the power, 2013-12-02 21:40:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/99653004/20001

[M-A Ruel, 2013-12-02 21:53:01]

you should use NOTRY=true for non-code change.

[jln (very slow on Chromium), 2013-12-02 22:01:14]

On 2013/12/02 21:53:01, M-A Ruel wrote:
> you should use NOTRY=true for non-code change.

Yeah, I expected it to skip all the tests automatically :(

[jln (very slow on Chromium), 2013-12-02 22:01:56]

Committed patchset #2 manually as r238199 (presubmit successful).