Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: content/public/browser/content_browser_client.h

Issue 9965091: Clean up RenderViewHostManager swapping logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index fcf53c78ccdaf3f846cb5b122653c85730c9bbae..9e18270d0fa6a3221a5aec0eee99063fd4100dd8 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -145,10 +145,13 @@ class CONTENT_EXPORT ContentBrowserClient {
virtual void SiteInstanceDeleting(SiteInstance* site_instance) {}
// Returns true if for the navigation from |current_url| to |new_url|,
- // processes should be swapped (even if we are in a process model that
- // doesn't usually swap).
- virtual bool ShouldSwapProcessesForNavigation(const GURL& current_url,
- const GURL& new_url);
+ // a new SiteInstance and BrowsingInstance should be created (even if we are
+ // in a process model that doesn't usually swap). This forces a process swap
+ // and severs script connections with existing tabs.
+ virtual bool ShouldSwapBrowsingInstanceForNavigation(
+ BrowserContext* browser_context,
+ const GURL& current_url,
+ const GURL& new_url);
// Returns true if the given navigation redirect should cause a renderer
// process swap.
« no previous file with comments | « content/browser/web_contents/render_view_host_manager_unittest.cc ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698