Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/debugger/devtools_manager_unittest.cc

Issue 9965091: Clean up RenderViewHostManager swapping logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge and clean up comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | content/browser/web_contents/render_view_host_manager.h » ('j') | content/browser/web_contents/render_view_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/devtools_manager_unittest.cc
diff --git a/content/browser/debugger/devtools_manager_unittest.cc b/content/browser/debugger/devtools_manager_unittest.cc
index 5f28d3a162c07c2a9e480859fffe2028c526707f..15f09dbd3a6518c916af1cd25c7a5c47f6371711 100644
--- a/content/browser/debugger/devtools_manager_unittest.cc
+++ b/content/browser/debugger/devtools_manager_unittest.cc
@@ -10,6 +10,7 @@
#include "content/browser/renderer_host/test_render_view_host.h"
#include "content/browser/web_contents/test_web_contents.h"
#include "content/common/view_messages.h"
+#include "content/public/browser/browser_context.h"
darin (slow to review) 2012/05/31 04:43:08 nit: this include is not needed, right?
Charlie Reis 2012/05/31 17:58:23 Done.
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/devtools_agent_host_registry.h"
#include "content/public/browser/devtools_client_host.h"
@@ -97,7 +98,8 @@ class DevToolsManagerTestBrowserClient
DevToolsManagerTestBrowserClient() {
}
- virtual bool ShouldSwapProcessesForNavigation(
+ virtual bool ShouldSwapBrowsingInstancesForNavigation(
+ content::BrowserContext* browser_context,
const GURL& current_url,
const GURL& new_url) OVERRIDE {
return true;
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | content/browser/web_contents/render_view_host_manager.h » ('j') | content/browser/web_contents/render_view_host_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698