Issue 9965064: Mac content shell: File > New makes a new browser window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9965064: Mac content shell: File > New makes a new browser window. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
jam, Cem Kocagil

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mac content shell: File > New makes a new browser window. BUG=120153 TEST=as described Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130140

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -19 lines)			Patch
M	content/shell/shell_application_mac.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/shell/shell_application_mac.mm	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	content/shell/shell_browser_context.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	content/shell/shell_browser_context.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Avi (use Gerrit)

Cem: FYI, this is what I was thinking of John: for review WDYT about making ...

8 years, 8 months ago (2012-04-02 16:05:05 UTC) #1

jam

lgtm I can't think of an issue with making ShellBrowserContext a singleton right. if we ...

8 years, 8 months ago (2012-04-02 16:21:59 UTC) #2

Avi (use Gerrit)

8 years, 8 months ago (2012-04-02 16:32:04 UTC) #3

I just don't want to hear the words "multi-profile" and "content shell" in the
same sentence...