Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 9965056: Merge 112539 - Web Inspector: "go to the previous panel" shortcut is painful to maintain (Closed)

Created:
8 years, 8 months ago by pfeldman
Modified:
8 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112539 - Web Inspector: "go to the previous panel" shortcut is painful to maintain https://bugs.webkit.org/show_bug.cgi?id=82602 Reviewed by Vsevolod Vlasov. Present go to previous panel shortcut "Cmd - Left" is painful to support since we have more and more free flow editing capabilities (where Cmd - Left is handled by the editor). Remaping it to Cmd - Option - [ (]) / (Ctrl - Alt - [ (]) ). Drive-by: de-capitalize captions from the settings panel. * English.lproj/localizedStrings.js: * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerShortcuts): * inspector/front-end/InspectorView.js: (WebInspector.InspectorView.prototype._keyDown): * inspector/front-end/ScriptsPanel.js: * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._registerShortcuts): (WebInspector.TimelinePanel.prototype._contextMenu): * inspector/front-end/inspector.js: (WebInspector._registerShortcuts): TBR=pfeldman@chromium.org BUGS=112539 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=112844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M Source/WebCore/inspector/front-end/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/InspectorView.js View 3 chunks +16 lines, -19 lines 0 comments Download
M Source/WebCore/inspector/front-end/ScriptsPanel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/TimelinePanel.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/front-end/inspector.js View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 8 months ago (2012-04-02 09:45:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698