ui/base: Clean up our AcceleratorGtk class.

ui/base: Clean up our AcceleratorGtk class.

Currently this class is fully implemented in the header file, and this have annoyed me for a long time.
Most of our class implementations reside in source files, so this patch fix this now. And this also makes
it easier to read.

R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130236

[sky, 2012-04-02 15:12:16]

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
File ui/base/accelerators/accelerator_gtk.cc (right):

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator_gtk.cc:16: key_code_ =
WindowsKeyCodeForGdkKeyCode(key_code);
use the member initializer list for these.

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator_gtk.cc:26: key_code_ = key_code;
use member initializer list for key_code_ and modifiers_.

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
File ui/base/accelerators/accelerator_gtk.h (left):

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator_gtk.h:48: GdkModifierType gdk_modifier_type()
const {
unix_hacker_style is fine for this.

[tfarina, 2012-04-02 20:25:16]

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
File ui/base/accelerators/accelerator_gtk.cc (right):

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator_gtk.cc:16: key_code_ =
WindowsKeyCodeForGdkKeyCode(key_code);
On 2012/04/02 15:12:16, sky wrote:
> use the member initializer list for these.

Done.

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator_gtk.cc:26: key_code_ = key_code;
On 2012/04/02 15:12:16, sky wrote:
> use member initializer list for key_code_ and modifiers_.

Done.

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
File ui/base/accelerators/accelerator_gtk.h (left):

http://codereview.chromium.org/9965049/diff/7013/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator_gtk.h:48: GdkModifierType gdk_modifier_type()
const {
On 2012/04/02 15:12:16, sky wrote:
> unix_hacker_style is fine for this.

Done.

[sky, 2012-04-02 21:27:45]

LGTM