Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 9965036: Update test suppressions / disabled tests following refactoring. (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, darin-cc_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Update test suppressions / disabled tests following refactoring. Some of these suppressed tests no longer exist or were renamed. They have not been failing since they were renamed, so it should be fine. Additionally, in the case of the CertVerifier tests, these tests now use a mock stub for testing caching behaviour, and thus no longer block dependent on the system libraries. R=wtc BUG=117372, 67599 TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130419

Patch Set 1 #

Patch Set 2 : Fix stray MAYBE_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M build/android/gtest_filter/net_unittests_disabled View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/multi_threaded_cert_verifier_unittest.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
wtc: PTAL.
8 years, 8 months ago (2012-03-30 21:57:49 UTC) #1
wtc
LGTM.
8 years, 8 months ago (2012-03-30 22:06:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9965036/2002
8 years, 8 months ago (2012-03-30 22:08:56 UTC) #3
commit-bot: I haz the power
Try job failure for 9965036-2002 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 8 months ago (2012-03-31 02:21:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9965036/2002
8 years, 8 months ago (2012-03-31 02:45:06 UTC) #5
commit-bot: I haz the power
Try job failure for 9965036-2002 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-03-31 05:24:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9965036/2002
8 years, 8 months ago (2012-04-02 18:48:14 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-02 22:22:21 UTC) #8
Try job failure for 9965036-2002 (retry) on win_rel for steps "browser_tests,
installer_util_unittests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698