Issue 9965032: gtk: Hide GTK and related dependencies for Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9965032: gtk: Hide GTK and related dependencies for Chrome OS (Closed)

Created:
8 years, 8 months ago by satorux1

Modified:
8 years, 8 months ago

Reviewers:
Elliot Glaysher, oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gtk: Hide GTK and related dependencies for Chrome OS so that they won't get added back by accident. BUG=118943 TEST=confirm chrome builds with chromeos==0 and chromeos==1, as well as in the chroot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129971

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -78 lines)			Patch
	M	build/linux/system.gyp	View	1	2 chunks	+77 lines, -78 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

satorux1

This is not a big deal, but wanted to be extra careful about the return ...

8 years, 8 months ago (2012-03-30 21:12:17 UTC) #1

oshima

one nit: http://codereview.chromium.org/9965032/diff/1/build/linux/system.gyp File build/linux/system.gyp (right): http://codereview.chromium.org/9965032/diff/1/build/linux/system.gyp#newcode37 build/linux/system.gyp:37: # misconfigured systems. 80 chars for comment

8 years, 8 months ago (2012-03-30 21:21:45 UTC) #3

satorux1

8 years, 8 months ago (2012-03-30 21:27:24 UTC) #5

http://codereview.chromium.org/9965032/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

http://codereview.chromium.org/9965032/diff/1/build/linux/system.gyp#newcode37
build/linux/system.gyp:37: # misconfigured systems.
On 2012/03/30 21:21:46, oshima wrote:
> 80 chars for comment

Done.

Expand Messages | Collapse Messages