Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: ui/views/examples/examples_window.cc

Issue 9965017: views: Rename ComboboxListener::ItemChanged to something more accurate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: combo_box -> combobox Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/examples/combobox_example.cc ('k') | ui/views/examples/native_theme_button_example.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/examples/examples_window.cc
diff --git a/ui/views/examples/examples_window.cc b/ui/views/examples/examples_window.cc
index 305d111ff9d37165329623827f5877b1710b1c06..17ba1a248252082ce471981cc9827ddb89259286 100644
--- a/ui/views/examples/examples_window.cc
+++ b/ui/views/examples/examples_window.cc
@@ -116,13 +116,12 @@ class ExamplesWindowContents : public WidgetDelegateView,
}
// Overridden from ComboboxListener:
- virtual void ItemChanged(Combobox* combo_box,
- int prev_index,
- int new_index) OVERRIDE {
- DCHECK(combo_box && combo_box == combobox_);
- DCHECK(new_index < combobox_model_.GetItemCount());
+ virtual void OnSelectedIndexChanged(Combobox* combobox) OVERRIDE {
+ DCHECK_EQ(combobox, combobox_);
+ DCHECK(combobox->selected_index() < combobox_model_.GetItemCount());
example_shown_->RemoveAllChildViews(false);
- example_shown_->AddChildView(combobox_model_.GetItemViewAt(new_index));
+ example_shown_->AddChildView(combobox_model_.GetItemViewAt(
+ combobox->selected_index()));
example_shown_->RequestFocus();
SetStatus(std::string());
Layout();
« no previous file with comments | « ui/views/examples/combobox_example.cc ('k') | ui/views/examples/native_theme_button_example.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698