Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/browser/ui/views/cookie_info_view.cc

Issue 9965017: views: Rename ComboboxListener::ItemChanged to something more accurate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: combo_box -> combobox Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/cookie_info_view.h ('k') | ui/views/controls/combobox/combobox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/cookie_info_view.cc
diff --git a/chrome/browser/ui/views/cookie_info_view.cc b/chrome/browser/ui/views/cookie_info_view.cc
index 993e68493df281d4e2157474b9ffd6d872ad8fb4..758acf8a081924487271347f3c898b835784d774 100644
--- a/chrome/browser/ui/views/cookie_info_view.cc
+++ b/chrome/browser/ui/views/cookie_info_view.cc
@@ -139,12 +139,10 @@ void CookieInfoView::ViewHierarchyChanged(bool is_add,
///////////////////////////////////////////////////////////////////////////////
// CookieInfoView, views::ComboboxListener overrides.
-void CookieInfoView::ItemChanged(views::Combobox* combo_box,
- int prev_index,
- int new_index) {
- DCHECK(combo_box == expires_value_combobox_);
+void CookieInfoView::OnSelectedIndexChanged(views::Combobox* combobox) {
+ DCHECK_EQ(combobox, expires_value_combobox_);
if (delegate_)
- delegate_->ModifyExpireDate(new_index != 0);
+ delegate_->ModifyExpireDate(combobox->selected_index() != 0);
}
///////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « chrome/browser/ui/views/cookie_info_view.h ('k') | ui/views/controls/combobox/combobox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698